Skip to content

Add LCKFB SZPI ESP32-S3-VA GC0308 camera example#6640

Open
xiasi0 wants to merge 2 commits into
esphome:currentfrom
xiasi0:add-lckfb-gc0308-camera-example
Open

Add LCKFB SZPI ESP32-S3-VA GC0308 camera example#6640
xiasi0 wants to merge 2 commits into
esphome:currentfrom
xiasi0:add-lckfb-gc0308-camera-example

Conversation

@xiasi0
Copy link
Copy Markdown

@xiasi0 xiasi0 commented May 17, 2026

Adds a tested esp32_camera example for the LCKFB SZPI ESP32-S3-VA development board with the onboard GC0308 camera.

The example includes the board-specific PCA9554/PCA9557 camera enable pin and uses PSRAM for the frame buffer.

Related issue: esphome/esphome#14993

esphome[bot]
esphome Bot previously requested changes May 17, 2026
Copy link
Copy Markdown

@esphome esphome Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 17, 2026

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 3ba2200
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/6a0ff6a34cf28a0008ef0f9c
😎 Deploy Preview https://deploy-preview-6640--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@xiasi0 xiasi0 marked this pull request as ready for review May 17, 2026 17:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Review Change Stack

Walkthrough

This PR adds a new documentation subsection to the ESP32 camera component guide with a complete ESPHome configuration example for the LCKFB SZPI ESP32-S3-VA with GC0308 camera board, including required component setup and board-specific pin mappings.

Changes

Camera Board Configuration Documentation

Layer / File(s) Summary
LCKFB SZPI ESP32-S3-VA with GC0308 configuration example
src/content/docs/components/esp32_camera.mdx
Added new documentation subsection with a board-specific configuration example, informational note about tested pin mappings, and complete YAML snippet covering PSRAM, PCA9554-based camera power/control switch, I2C bus, and esp32_camera component settings with pin assignments, clock configuration, resolution, framerate, pixel format, JPEG quality, and exposure/gain parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • esphome/esphome-docs#5710: Updates ESP32 camera documentation prerequisites to explicitly require PSRAM, complementing this PR's board-specific configuration example that depends on PSRAM and I2C requirements.

Suggested reviewers

  • kbx81
  • ssieb
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a camera configuration example for a specific ESP32 board model.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly describes the changes: adding an esp32_camera example for a specific development board with configuration details about the camera pin and PSRAM usage.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/content/docs/components/esp32_camera.mdx (1)

246-248: ⚡ Quick win

Consider clarifying the PCA9554/PCA9557 component relationship.

The component type is pca9554 but the ID is named pca9557pw_device, which may confuse users about which device is actually on the board. While PCA9557 and PCA9554 are compatible and using the pca9554 component for PCA9557 hardware is correct, adding a brief comment would improve clarity.

📝 Suggested clarification
 pca9554:
+  # PCA9557 is compatible with PCA9554 component
   - id: pca9557pw_device
     address: 0x19

Alternatively, use a more generic ID name:

 pca9554:
-  - id: pca9557pw_device
+  - id: camera_io_expander
     address: 0x19

And update the reference:

     pin:
-      pca9554: pca9557pw_device
+      pca9554: camera_io_expander
       number: 2
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/content/docs/components/esp32_camera.mdx` around lines 246 - 248, The
YAML shows component type pca9554 with id pca9557pw_device which is confusing;
either rename the id to a neutral name (e.g., pca95xx_device or pca9557_device)
or add an inline comment next to the pca9554 entry explaining that PCA9557
hardware is compatible and intentionally uses the pca9554 component; if you
rename the id, also update any references to pca9557pw_device elsewhere in the
docs/config so they point to the new id.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/content/docs/components/esp32_camera.mdx`:
- Around line 246-248: The YAML shows component type pca9554 with id
pca9557pw_device which is confusing; either rename the id to a neutral name
(e.g., pca95xx_device or pca9557_device) or add an inline comment next to the
pca9554 entry explaining that PCA9557 hardware is compatible and intentionally
uses the pca9554 component; if you rename the id, also update any references to
pca9557pw_device elsewhere in the docs/config so they point to the new id.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 312a6695-214d-4a1d-98b4-0b9fafca4f03

📥 Commits

Reviewing files that changed from the base of the PR and between f33636d and 9f83ff9.

📒 Files selected for processing (1)
  • src/content/docs/components/esp32_camera.mdx

@esphome esphome Bot dismissed their stale review May 17, 2026 17:13

Base branch has been corrected - dismissing previous review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant