Skip to content

IEP-1786 Make update site self-contained with includeAllDependencies#1480

Open
sigmaaa wants to merge 1 commit into
masterfrom
IEP-1786
Open

IEP-1786 Make update site self-contained with includeAllDependencies#1480
sigmaaa wants to merge 1 commit into
masterfrom
IEP-1786

Conversation

@sigmaaa

@sigmaaa sigmaaa commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Description

After deleting the p2 folder and retesting the lightweight online update site, I noticed an issue when updating from older versions that I haven't been able to resolve yet. However, we still need a reliable and robust update site that is easy to maintain and can handle updates from older IDE versions. Therefore, I decided to move the offline update site approach from this PR: #1474 into this one.

Fixes # (IEP-1786)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Update 4.x Espressif-IDE/ plugin with this update site
  • Update 3.x Espressif-IDE/plugin with this update site

Note: Use the update option

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Update site

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated release build configuration to include core platform components and dependencies.
    • Reorganized category definitions to streamline plugin distribution and dependency management.

@sigmaaa sigmaaa self-assigned this Jun 17, 2026
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The P2 update site configuration is restructured: category.xml removes the com.espressif.idf.dependencies category along with its feature/bundle entries, introduces a new com.espressif.idf.platform category containing three core Eclipse platform features, and updates category definitions. pom.xml adds a Tycho tycho-p2-repository-plugin build block with includeAllDependencies=true.

Changes

P2 Update Site Restructure

Layer / File(s) Summary
category.xml: new platform features and category definitions
releng/com.espressif.idf.update/category.xml
Removes all prior <feature> and <bundle> entries under com.espressif.idf and com.espressif.idf.dependencies. Adds org.eclipse.rcp, org.eclipse.platform, and org.eclipse.equinox.p2.user.ui features under the new com.espressif.idf.platform category. Replaces the com.espressif.idf.dependencies category-def with a new com.espressif.idf.platform category-def and trims the com.espressif.idf category-def.
pom.xml: Tycho build with includeAllDependencies
releng/com.espressif.idf.update/pom.xml
Adds a <build> section configuring org.eclipse.tycho:tycho-p2-repository-plugin with includeAllDependencies=true to pull all transitive dependencies into the generated p2 repository.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • espressif/idf-eclipse-plugin#1391: Modifies the same category.xml file by adding org.eclipse.terminal.feature and org.eclipse.launchbar entries under com.espressif.idf.dependencies, the category this PR removes.
  • espressif/idf-eclipse-plugin#1393: Also edits category.xml by removing a JRE feature entry from com.espressif.idf.dependencies, intersecting with the broader cleanup of that category in this PR.

Suggested reviewers

  • kolipakakondal

Poem

🐇 Hop hop, the old dependencies are gone,
A platform category now carries on,
org.eclipse.rcp joins the dance,
includeAllDependencies — take a chance!
The update site hops neatly into place. 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: making the update site self-contained using includeAllDependencies, which aligns with the pom.xml modification adding tycho-p2-repository-plugin with includeAllDependencies configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch IEP-1786

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kolipakakondal kolipakakondal added this to the v4.4.0 milestone Jun 18, 2026

@AndriiFilippov AndriiFilippov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sigmaaa hi !
LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants