WIP: fix CMake and try new images with hwloc

Author: jngrad

.github/workflows/push_pull.yml

@@ -52,7 +52,7 @@ jobs:
   debian:
     runs-on: ubuntu-latest
     container:
-      image: ghcr.io/espressomd/docker/debian:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc-base-layer
+      image: ghcr.io/jngrad/espresso-docker/debian:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc-base-layer
       credentials:
          username: ${{ github.actor }}
          password: ${{ secrets.github_token }}
@@ -93,7 +93,7 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ github.repository == 'espressomd/espresso' }}
     container:
-      image: ghcr.io/espressomd/docker/ubuntu-wo-dependencies:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc-base-layer
+      image: ghcr.io/jngrad/espresso-docker/ubuntu-wo-dependencies:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc-base-layer
       credentials:
          username: ${{ github.actor }}
          password: ${{ secrets.github_token }}
@@ -135,7 +135,7 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ github.repository == 'espressomd/espresso' }}
     container:
-      image: ghcr.io/espressomd/docker/fedora:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc-base-layer
+      image: ghcr.io/jngrad/espresso-docker/fedora:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc-base-layer
       credentials:
          username: ${{ github.actor }}
          password: ${{ secrets.github_token }}
@@ -165,7 +165,7 @@ jobs:
           with_hdf5: 'true'
           with_fftw: 'true'
           with_fpe: 'true'
-          with_gsl: 'false'
+          with_gsl: 'true'
           with_scafacos: 'false'
           with_walberla: 'true'
           with_walberla_avx: 'false'

.gitlab-ci.yml

@@ -1,4 +1,4 @@
-image: ghcr.io/espressomd/docker/ubuntu:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc
+image: ghcr.io/jngrad/espresso-docker/ubuntu:4d3e236db5ae334ddcc9c3c82aae7637faa5dabc
 
 stages:
   - prepare

CMakeLists.txt

@@ -680,7 +680,6 @@ if(NOT DEFINED Kokkos_FOUND OR NOT ${Kokkos_FOUND})
     TARGET kokkos APPEND
     PROPERTY INTERFACE_SYSTEM_INCLUDE_DIRECTORIES
              $<TARGET_PROPERTY:kokkos,INTERFACE_INCLUDE_DIRECTORIES>)
-  set_target_properties(kokkos PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "")
 endif()
 
 if(NOT EXISTS ${FETCHCONTENT_BASE_DIR}/cabana-src)
@@ -697,6 +696,11 @@ if(NOT DEFINED Cabana_FOUND OR NOT ${Cabana_FOUND})
   # cmake-format: on
   set(Cabana_REQUIRE_HEFFTE ${ESPRESSO_BUILD_WITH_FFTW} CACHE BOOL "")
   FetchContent_MakeAvailable(cabana)
+  # mark Cabana headers as system headers to disable compiler diagnostics
+  set_property(
+    TARGET Core APPEND
+    PROPERTY INTERFACE_SYSTEM_INCLUDE_DIRECTORIES
+             $<TARGET_PROPERTY:Core,INTERFACE_INCLUDE_DIRECTORIES>)
 endif()
 
 # We need the parallel hdf5 version!

src/core/particle_reduction.hpp

@@ -58,7 +58,7 @@ template <typename ResultType, typename Kernel> class KokkosReducer {
   KokkosReducer(Kernel kernel, ReductionOp<ResultType> reduction_op)
       : reduction_op(std::move(reduction_op)), kernel(std::move(kernel)) {}
   KokkosReducer(KokkosReducer const &other)
-      : reduction_op(other.reduction_op), kernel(other.kernel) {};
+      : reduction_op(other.reduction_op), kernel(other.kernel) {}
 
   KOKKOS_INLINE_FUNCTION void operator()(std::integral auto const i,
                                          value_type &update) const {