fix: skip non-Kubernetes entries in analyze output#484
Open
immanuwell wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: immanuwell The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix/analyze-skip-non-k8s-entries
branch
from
June 1, 2026 05:39
39828d7 to
d6fef93
Compare
| @@ -45,7 +47,11 @@ func init() { | |||
| } | |||
|
|
|||
| func analyzeValidateAndRun() error { | |||
Contributor
There was a problem hiding this comment.
is this func still needed?
| for i, entry := range entries { | ||
| fmt.Printf("\t%d\t%s\n", entry.count, entry.gvk) | ||
| if i > 10 { | ||
| if i >= 10 { |
Contributor
There was a problem hiding this comment.
Thanks for the fix. is the change from i > 10 to i >= 10 relevant to the fix?
hwdef
reviewed
Jun 1, 2026
| fmt.Printf("Current (latest revision) storage used by kubernetes objects: %d\n", totalKeySize+totalValueSize) | ||
| fmt.Printf("\n") | ||
| fmt.Printf("Most common kubernetes types:\n") | ||
| fmt.Fprintf(out, "Total kubernetes objects: %d\n", len(summaries)) |
Member
There was a problem hiding this comment.
Suggested change
| fmt.Fprintf(out, "Total kubernetes objects: %d\n", len(summaries)) | |
| fmt.Fprintf(out, "Total objects: %d\n", len(summaries)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a panic in
auger analyzewhen the db has non-Kubernetes keys likecompact_rev_key.it was assuming every entry had
TypeMeta, so theLargest objectssection could blow up. this skips entries without Kubernetes metadata and adds a regression test.how to repro
go run . analyze -f cmd/testdata/boltdb/dbbefore this panics with a nil pointer dereference
after it prints the report and exits cleanly