Reimplement the feature of support setting data file size limit#1210
Merged
Conversation
- Update fillDBWithKeys to accept a configurable value size - Fix TestDB_MaxSizeNotExceeded to use larger values that trigger grow - Remove Windows skip from TestDB_MaxSizeExceededCanOpenWithHighMmap - Rewrite TestDB_MaxSizeExceededDoesNotGrow with table-driven sub-tests covering InitialMmapSize variants on Windows - Add TestDB_MaxSizeWithHighInitialMMapDoesNotGrowOnWrite for non-Windows Signed-off-by: elbehery <elbeherymustafa@gmail.com>
Member
|
/ok-to-test |
Member
Author
|
Yeah GH Actions is hallucinating |
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Elbehery
force-pushed
the
20260526_support_data_size_limit
branch
from
May 26, 2026 12:58
9e9dae1 to
a85b887
Compare
Member
Author
|
It is running now 👍🏽 |
ahrtr
changed the title
Windows env.
Member
ahrtr
approved these changes
May 26, 2026
This was referenced May 26, 2026
fuweid
approved these changes
May 26, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, Elbehery, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
🎊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1108
Continuation of #1130
Supersedes #1205
cc @ahrtr @ivanvc @fuweid @serathius