decouple raftLog - phase 1: introduce the new type controlflowLog.#292
decouple raftLog - phase 1: introduce the new type controlflowLog.#292IAMRogerXi wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: IAMRogerXi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @IAMRogerXi. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
#142 - this is about to decouple the type raftLog.
since this change may include a lot of cascaded code changes on several types, i'd like to split this refactor into two phase.
phase 1: introduce the type controlflowLog. add it back into raftLog as embedding type.
i move all control flow related fields into type controlflowLog.
phase 2: remove the embedding type. modify type reference in all other files.
in this PR, i implemented phase 1. please review it.