Docs: add missing logging flags to configuration guide#1104
Conversation
|
Hi @Mvrk08. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hello @ronaldngounou i took the opportunity to make a pr let me know if any more changes are required or not |
|
|
||
| ```nocode | ||
| --logger 'zap' | ||
| Specify 'zap' for structured logging or 'capnslog'. |
There was a problem hiding this comment.
CodeRef says that 'zap' is only supported for structured logging. capnslog is removed in v3.5?
There was a problem hiding this comment.
Yes you are right .. 'capnslog' is depriciated in v3.5 removed it
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
2 times, most recently
from
26c7988 to
76d6f84
Compare
Mvrk08
force-pushed
the
docs-add-logging-flags
branch
from
76d6f84 to
5d1816a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mvrk08 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
updated pr #1106 |
3 participants
Description :
This PR updates the Configuration Guide to include the missing Logging flags section, as requested in parent issue #1074
The following flags have been added to match the server code in
config.go:--logger--log-outputs--log-level--log-format--enable-log-rotation--log-rotation-config-jsonRelated Issue :
Fixes part of #1074