docs: automate release metrics generation#1151
Conversation
Signed-off-by: AR21SM <mahajanashishar21sm@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AR21SM The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @AR21SM. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| etcd_disk_wal_write_duration_seconds_bucket{le="0.001"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.002"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.004"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.008"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.016"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.032"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.064"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.128"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.256"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="0.512"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="1.024"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="2.048"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="4.096"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="8.192"} | ||
| etcd_disk_wal_write_duration_seconds_bucket{le="+Inf"} |
There was a problem hiding this comment.
Does it actually help users to output all of these bucket thresholds in this format?
3 participants
What changed
This PR adds a script to update the generated metrics file from the etcd source.
It uses the existing
tools/etcd-dump-metricstool from etcd repo.I also added make targets for updating and verifying the metrics docs, and updated the release version script so future release updates can also refresh the metrics file.
This PR regenerates the v3.6 metrics file from
v3.6.0.closes #1133
Note
I did not update v3.7 metrics in this PR because v3.7 is still draft and uses
git_version_tag: main. I kept the script limited to released etcd tags to avoid committing metrics generated from a moving branch.If maintainers want draft docs to track metrics from
main, I can add that separately.