Skip to content

Reject existing-user claims in FastAPI signup flow #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrivateBasicsApp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reject existing-user claims in FastAPI signup flow #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions etebase_server/fastapi/routers/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ def signup_save(data: SignupIn, request: Request) -> UserType:
with transaction.atomic():
try:
user_queryset = get_user_queryset(User.objects.all(), CallbackContext(request.path_params))
instance = user_queryset.get(**{User.USERNAME_FIELD: user_data.username.lower()})
user_queryset.get(**{User.USERNAME_FIELD: user_data.username.lower()})
raise HttpError("user_exists", "User already exists", status_code=status.HTTP_409_CONFLICT)
except User.DoesNotExist:
# Create the user and save the casing the user chose as the first name
try:
Expand All @@ -249,9 +250,6 @@ def signup_save(data: SignupIn, request: Request) -> UserType:
except Exception as e:
raise HttpError("generic", str(e))

if hasattr(instance, "userinfo"):
raise HttpError("user_exists", "User already exists", status_code=status.HTTP_409_CONFLICT)

models.UserInfo.objects.create(**data.dict(exclude={"user"}), owner=instance)
return instance

Expand Down