Firecracking logging improvement on WN

Signed-off-by: Lazar Cvetković <l.cvetkovic.997@gmail.com>

Author: cvetkovic

cmd/worker_node/config_cluster.yaml

@@ -15,8 +15,8 @@ firecracker:
   FileSystem: "/cluster_manager/configs/firecracker/rootfs.ext4"
   InternalIPPrefix: "100"
   VMDebugMode: false
-  UseSnapshots: true
-  NetworkPoolSize: 128
+  UseSnapshots: false
+  NetworkPoolSize: 0
 
 dandelion:
   daemonPort: 8080

internal/worker_node/sandbox/firecracker/iface.go

@@ -60,7 +60,7 @@ func makeFirecrackerConfig(vmcs *VMControlStructure, vmDebugMode bool) {
 		KernelImagePath: vmcs.KernelPath,
 		KernelArgs:      kernelArgs,
 		LogPath:         fmt.Sprintf(pathToLog, vmcs.SandboxID),
-		LogLevel:        "Info",
+		LogLevel:        "Debug",
 		Drives: []models.Drive{{
 			DriveID:      firecracker.String("1"),
 			PathOnHost:   firecracker.String(vmcs.FileSystemPath),

internal/worker_node/sandbox/firecracker/networking.go

@@ -48,10 +48,13 @@ func NewNetworkPoolManager(internalPrefix, externalPrefix string, networkPoolSiz
 	internalIPManager := managers.NewIPManager(internalPrefix)
 	externalIPManager := managers.NewIPManager(externalPrefix)
 
-	// NetworkPoolSize should be divisible by 16
-	networkPoolSize -= networkPoolSize % 16
-	if networkPoolSize < 16 {
-		networkPoolSize = 16
+	// if 0 then pooling is disabled
+	if networkPoolSize > 0 {
+		// NetworkPoolSize should be divisible by 16
+		networkPoolSize -= networkPoolSize % 16
+		if networkPoolSize < 16 {
+			networkPoolSize = 16
+		}
 	}
 
 	pool := &NetworkPoolManager{

internal/worker_node/sandbox/firecracker/runtime.go

@@ -99,6 +99,7 @@ func createMetadata(in *proto.ServiceInfo, vmcs *VMControlStructure) *managers.M
 }
 
 func (fcr *Runtime) CreateSandbox(ctx context.Context, in *proto.ServiceInfo) (*proto.SandboxCreationStatus, error) {
+	logrus.Infof("Create Firecracker VM for %s received", in.Name)
 	start := time.Now()
 
 	vmcs := fcr.createVMCS()
@@ -262,15 +263,15 @@ func (fcr *Runtime) ListEndpoints(_ context.Context, _ *emptypb.Empty) (*proto.E
 	return fcr.SandboxManager.ListEndpoints()
 }
 
-func (fcr *Runtime) PrepullImage(grpcCtx context.Context, imageInfo *proto.ImageInfo) (*proto.ActionStatus, error) {
+func (fcr *Runtime) PrepullImage(_ context.Context, _ *proto.ImageInfo) (*proto.ActionStatus, error) {
 	// TODO: Implement Firecracker image fetching.
 	return &proto.ActionStatus{
 		Success: false,
 		Message: "Firecracker runtime does not currently support prepulling images.",
 	}, nil
 }
 
-func (fcr *Runtime) GetImages(grpcCtx context.Context) ([]*proto.ImageInfo, error) {
+func (fcr *Runtime) GetImages(_ context.Context) ([]*proto.ImageInfo, error) {
 	// TODO: Implement Firecracker image fetching.
 	return []*proto.ImageInfo{}, errors.New("image pulling in Firecracker not implemented yet")
 }

internal/worker_node/sandbox/firecracker/vm.go

@@ -67,11 +67,11 @@ func StartFirecrackerVM(networkManager *NetworkPoolManager, vmcs *VMControlStruc
 
 	makeFirecrackerConfig(vmcs, vmDebugMode)
 	newMachineOpts := []firecracker.Opt{firecracker.WithProcessRunner(getVMCommandBuild(vmcs))}
-	if vmDebugMode {
-		logger := logrus.New()
-		logger.SetLevel(logrus.GetLevel())
-		newMachineOpts = append(newMachineOpts, firecracker.WithLogger(logrus.NewEntry(logger)))
-	}
+
+	logger := logrus.New()
+	logger.SetLevel(logrus.GetLevel())
+	logger.SetFormatter(&logrus.TextFormatter{TimestampFormat: time.StampMilli, FullTimestamp: true})
+	newMachineOpts = append(newMachineOpts, firecracker.WithLogger(logrus.NewEntry(logger)))
 
 	// TODO: pass environment variables (sandbox configuration) to Firecracker VM somehow