ci: fix mac builds by using native macos-latest runner#364
Open
S1M0N38 wants to merge 1 commit into
Open
Conversation
The cross-compilation via cargo-zigbuild on Ubuntu was broken due to Dobby's cmake build not producing the correct symbols when targeting macOS from Linux. Using a native macos-latest runner fixes this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the long-standing Mac CI failure by switching
build-macfrom broken cross-compilation onubuntu-latest(viacargo-zigbuild+ downloaded macOS SDKs) to native builds onmacos-latest. No source code changes.The upstream Mac CI has never succeeded — both v0.8.0 and v0.9.0 Release runs failed with
exit code 101(undefined symbol: _CodePatchfrom Dobby's cmake cross-compile). Mac binaries were manually uploaded by @WilsontheWolf.Change:
runs-on: ubuntu-latest→runs-on: macos-latest, removes Mac SDK download + cargo-zigbuild install, uses plaincargo build.CI tested on fork: run #25866393197 · release — all 4 artifacts (Mac ARM, Mac x86, Linux x86, Windows x86) built and uploaded successfully.
PR 🤖 generated on behalf of @S1M0N38