Commit d195d9a
test(playwright): fix align spec — overlay click + wrong assert target
Two bugs in the migrated Playwright spec (#7622) caused every CI run
on ether/etherpad with WITH_PLUGINS=1 to fail (chromium + firefox):
1. After selectAllText(), the #toolbar-overlay div in core's pad.html
intercepts pointer events on the alignment buttons, so the click
times out (90s). Mirror the {force: true} pattern that
ep_etherpad-lite's clearAuthorship() helper already uses for the
same reason.
2. The assertion read style from the inner <span>, but ep_align's
aceDomLineProcessLineAttributes (static/js/index.js) renders the
text-align style on the wrapping block element (<left>, <center>,
<right>, <justify>), not on the span. Read it from the wrapper and
use toHaveAttribute() so the assertion retries while the DOM
settles.
Verified locally against an Etherpad instance running ep_align@10.0.2:
all four `Alignment of Text` cases pass; reverting either change
reproduces the CI failure (\"Received string: ''\").
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent ef38ef0 commit d195d9a
1 file changed
Lines changed: 11 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | | - | |
21 | | - | |
22 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
23 | 30 | | |
24 | 31 | | |
25 | 32 | | |
| |||
0 commit comments