feat: migrate to ep_plugin_helpers/toolbar-select

[JohnMcLear]

Summary

Replaces the hand-rolled <select> change handler with the shared toolbarSelect helper from ep_plugin_helpers#17.

- const hs = $('#heading-selection');
- hs.on('change', function () {
-   const value = $(this).val();
-   const intValue = parseInt(value, 10);
-   if (!isNaN(intValue)) {
-     context.ace.callWithAce((ace) => {
-       ace.ace_doInsertHeading(intValue);
-     }, 'insertheading', true);
-     hs.val('dummy');
-   }
-   // Return focus to the editor after heading selection (fixes #130)
-   context.ace.focus();
- });
+ toolbarSelect({
+   selector: '#heading-selection',
+   context,
+   invoke: (ace, value) => ace.ace_doInsertHeading(value),
+   op: 'insertheading',
+ });

Behavioral notes

Fully behavior-preserving for this plugin — the previous code already restored focus unconditionally (the #130 fix), which is exactly what the helper guarantees. The existing select_focus_restore.spec.ts in core (which targets #heading-selection specifically) should continue to pass without modification.

Status

Draft — depends on:

1. feat(toolbarSelect): DRY up the toolbar <select>-change boilerplate ep_plugin_helpers#17 merging
2. ep_plugin_helpers ≥ 0.6.0 published to npm

Refs ether/etherpad#7255

🤖 Generated with Claude Code

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →