Skip to content

Commit d40113b

Browse files
authored
fix(ci): drop hardcoded pnpm version, defer to packageManager (#12)
* fix(ci): drop hardcoded pnpm version 10, defer to packageManager The publish job checks out etherpad-lite core first (pinned to pnpm@11 via packageManager); pnpm/action-setup@v6 then errors with 'Multiple versions of pnpm specified' because the workflow's version: 10 clashes with the checked-out repo's packageManager. Removing 'version:' lets action-setup take pnpm@11 from packageManager, which is what we actually want for compatibility with the rest of the plugin ecosystem and what the test job already does. * build: pin packageManager to pnpm@11.0.6 action-setup infers the pnpm version from this field. The test job doesn't check out an upstream repo, so without it action-setup errors 'No pnpm version is specified'.
1 parent 57bd097 commit d40113b

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/npmpublish.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ jobs:
3434
- uses: pnpm/action-setup@v6
3535
name: Install pnpm
3636
with:
37-
version: 10
37+
# No `version:` here — defer to packageManager in package.json so
38+
# we don't get the "Multiple versions of pnpm specified" error
39+
# when an upstream checkout (etherpad-lite) pins a different
40+
# pnpm via packageManager. See pnpm/action-setup#225.
3841
run_install: false
3942
- name: Get pnpm store directory
4043
shell: bash

.github/workflows/test-and-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
node-version: 20
1616
- uses: pnpm/action-setup@v6
1717
with:
18-
version: 10
18+
# No `version:` — defer to packageManager in package.json.
1919
run_install: false
2020
- name: Get pnpm store directory
2121
shell: bash

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"type": "individual",
2929
"url": "https://etherpad.org/"
3030
},
31+
"packageManager": "pnpm@11.0.6",
3132
"scripts": {
3233
"lint": "eslint .",
3334
"lint:fix": "eslint --fix .",

0 commit comments

Comments
 (0)