fix(release): unbreak Linux deb + Snap + Windows builds post-monorepo (#47)

Three regressions surfaced when v0.4.0 (the first release-please run
under the new monorepo layout) tried to build:

1. Linux `.deb` — fpm failed with "Parent directory does not exist:
   .../release/@etherpad". electron-builder defaults the deb artifact
   path + executable name to `package.json#name`, which is now the
   scoped `@etherpad/desktop`. The `/` from the scope became a
   directory in the output path.
2. Snap — `expected argument for flag '--executable'` followed by
   `ERR_ELECTRON_BUILDER_CANNOT_EXECUTE`. Same root cause as deb: the
   snap `--executable` argument can't carry a scoped name.
3. Windows — `[fetch-etherpad] failed: spawn pnpm ENOENT`. The
   embedded-server fetch script spawned `pnpm` without going through
   a shell, but on Windows pnpm resolves to `pnpm.cmd` which Node's
   `child_process.spawn` won't find without `shell: true`.

Fixes:

- Add `linux.executableName: etherpad-desktop` to
  `packages/desktop/build/electron-builder.yml`. That pins a
  slash-free name for both deb and snap targets in one shot.
- Add `shell: process.platform === 'win32'` to the `spawn` call in
  `packages/desktop/scripts/fetch-etherpad.mjs`. Same pattern we
  used upstream in ether/etherpad's `admin/scripts/gen-api.mjs`.

These are pre-existing post-#29/#30 regressions; v0.3.2 was built
before the monorepo move, so its non-scoped root name shielded it.

The macOS build + Linux AppImage already succeed at v0.4.0, so this
PR's verification is the next tag rebuild.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: JohnMcLear

packages/desktop/build/electron-builder.yml

@@ -36,6 +36,15 @@ linux:
     - AppImage
     - deb
     - snap
+  # `package.json#name` is `@etherpad/desktop` (scoped). electron-builder
+  # uses that as the default executable + artifact basename for the deb
+  # and snap targets, and the `/` in the scope becomes a directory in
+  # the output path — so deb/snap builds crash with "Parent directory
+  # does not exist: release/@etherpad". Snap additionally crashes
+  # earlier with "expected argument for flag '--executable'" because
+  # the scoped name doesn't satisfy the snap binary-naming rules.
+  # Pinning a slash-free executable name fixes both.
+  executableName: etherpad-desktop
   category: Office
   icon: build/icons/
   description: Native desktop client for Etherpad

packages/desktop/scripts/fetch-etherpad.mjs

@@ -44,7 +44,16 @@ async function exists(p) {
 
 async function run(cmd, args, opts = {}) {
   return new Promise((resolveP, rejectP) => {
-    const child = spawn(cmd, args, { stdio: 'inherit', ...opts });
+    // On Windows, pnpm/tar/etc. resolve to .cmd or .ps1 shims, and Node's
+    // spawn() won't find them without going through a shell. Use shell:true
+    // on win32 only to avoid Node's DEP0190 warning elsewhere. All cmd/arg
+    // values here are hardcoded by us, so the shell variant is not an
+    // injection risk.
+    const child = spawn(cmd, args, {
+      stdio: 'inherit',
+      shell: process.platform === 'win32',
+      ...opts,
+    });
     child.on('exit', (code) => {
       if (code === 0) resolveP();
       else rejectP(new Error(`${cmd} ${args.join(' ')} exited ${code}`));