Skip to content

Commit 6e3f929

Browse files
JohnMcLearclaude
andauthored
test: tag two line-numbers-touching pad_settings specs with @feature:line-numbers (#7658)
Surfaced by ep_hide_line_numbers' red main. Two pad_settings specs use `expect(...).not.toHaveClass(/line-numbers-hidden/)` to verify the line-number gutter is visible by default before settings flip it on, but plugins that hide line numbers (ep_hide_line_numbers sets `pad.changeViewOption('showLineNumbers', false)` in postAceInit) keep that class on the body for the entire pad lifetime. Tag the two affected specs with @feature:line-numbers so plugins that hide line numbers can declare `disables: ["@feature:line-numbers"]` in ep.json and have these excluded from pass-1 regression while still failing pass-2 honesty (plugin must actually keep them hidden). Companion to the existing tag set (@feature:chat, @feature:username, @feature:clear-authorship, @feature:error-gritter, @feature:authorship-bg-color). See doc/PLUGIN_FEATURE_DISABLES.md. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0be8afc commit 6e3f929

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

src/tests/frontend-new/specs/pad_settings.spec.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ test.describe('creator-owned pad settings', () => {
2828
await context2.close();
2929
});
3030

31-
test('pad settings act as defaults until enforcement is enabled', async ({page, browser}) => {
31+
test('pad settings act as defaults until enforcement is enabled', {
32+
tag: '@feature:line-numbers',
33+
}, async ({page, browser}) => {
3234
const padId = await goToNewPad(page);
3335

3436
const context2 = await browser.newContext();
@@ -122,7 +124,9 @@ test.describe('creator-owned pad settings', () => {
122124
await context2.close();
123125
});
124126

125-
test('uses My View defaults for newly created pads without changing an existing pad default',
127+
test('uses My View defaults for newly created pads without changing an existing pad default', {
128+
tag: '@feature:line-numbers',
129+
},
126130
async ({page}) => {
127131
await goToNewPad(page);
128132
const creatorOuter = page.frameLocator('iframe[name="ace_outer"]').locator('#outerdocbody');

0 commit comments

Comments
 (0)