Skip to content

Commit 934ec7b

Browse files
committed
test(admin): pass hook timeout as before() arg, not vi.setConfig
vi.setConfig({hookTimeout: N}) inside a before() callback is a no-op — vitest reads hook timeouts before the hook runs. padLoadFilter genuinely needs 120s for its setup, so pass it as the second arg. The two 60s files drop the override entirely (matches the global default already set in vitest.config.ts).
1 parent d8eeee8 commit 934ec7b

3 files changed

Lines changed: 1 addition & 7 deletions

File tree

src/tests/backend/specs/admin/adminSettingsResolved.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
import {strict as assert} from 'assert';
4-
import {vi} from 'vitest';
54
import setCookieParser from 'set-cookie-parser';
65
import * as fs from 'fs';
76
import * as os from 'os';
@@ -96,7 +95,6 @@ describe(__filename, () => {
9695
let skipReason: string | null = null;
9796

9897
before(async () => {
99-
vi.setConfig({hookTimeout: 60000});
10098
await common.init();
10199

102100
// The load handler bails with logger.error + early return if the

src/tests/backend/specs/admin/adminSettingsSave.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
import {strict as assert} from 'assert';
4-
import {vi} from 'vitest';
54
import setCookieParser from 'set-cookie-parser';
65
import * as fs from 'fs';
76
import * as os from 'os';
@@ -109,7 +108,6 @@ describe(__filename, () => {
109108
let skipReason: string | null = null;
110109

111110
before(async () => {
112-
vi.setConfig({hookTimeout: 60000});
113111
await common.init();
114112

115113
savedSettingsFilename = settings.settingsFilename;

src/tests/backend/specs/admin/padLoadFilter.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
// offset/limit slice, so `total` reflects the filtered universe.
1010

1111
import {strict as assert} from 'assert';
12-
import {vi} from 'vitest';
1312
import setCookieParser from 'set-cookie-parser';
1413

1514
const io = require('socket.io-client');
@@ -100,7 +99,6 @@ describe(__filename, () => {
10099
const editedPadIds: string[] = [];
101100

102101
before(async () => {
103-
vi.setConfig({hookTimeout: 120000});
104102
await common.init();
105103

106104
savedUsers = settings.users;
@@ -132,7 +130,7 @@ describe(__filename, () => {
132130
await pad.setText(`seed-${i}\n`, `m-${tag}-${i}`);
133131
editedPadIds.push(id);
134132
}
135-
});
133+
}, 120000);
136134

137135
after(async () => {
138136
if (socket) socket.disconnect();

0 commit comments

Comments
 (0)