Skip to content

Commit a83054c

Browse files
JohnMcLearclaude
andcommitted
fix(reviews): include fingerprint/file/ruleId in all decision appends
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8d9d8d9 commit a83054c

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.claude/commands/release-review.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,15 @@ Track decisions in an array. For EACH finding, in this order:
106106
2. **issue bucket**:
107107
- Print finding. Draft a GitHub issue body (Title: `<rule>: <one-liner>`. Body: severity, file:line, message, remediation, links).
108108
- Ask: "Create issue / edit body / skip?"
109-
- On create: run `gh issue create --title "..." --body-file -` (with confirmation). Capture issue URL. Append `{action: 'issue', issueUrl}`.
109+
- On create: run `gh issue create --title "..." --body-file -` (with confirmation). Capture issue URL. Append `{fingerprint, action: 'issue', file, ruleId, issueUrl}`.
110+
- On skip: append `{fingerprint, action: 'skip', file, ruleId}`.
110111
- If `gh` is missing: print the body, append `{action: 'skip', rationale: 'gh not available'}`.
111112

112113
3. **suppress bucket**:
113114
- Print finding + propose `status: accepted-risk` (default) and a one-line rationale based on the message.
114115
- Ask: "Accept / edit rationale / fix-instead / skip?"
115-
- On accept: invoke `cli.ts append-suppression` with the entry. Append `{action: 'accepted-risk', rationale}`.
116+
- On accept: invoke `cli.ts append-suppression` with the entry. Append `{fingerprint, action: 'accepted-risk', file, ruleId, rationale}`.
117+
- On skip: append `{fingerprint, action: 'skip', file, ruleId}`.
116118
- On fix-instead: jump to the fixNow flow for this finding.
117119

118120
### 3e. End-of-session summary

0 commit comments

Comments
 (0)