Skip to content

test(backend): fix Windows ENOENT in backend-tests-glob regression check #7794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 2 commits into from
May 17, 2026
Merged

test(backend): fix Windows ENOENT in backend-tests-glob regression check #7794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db93fd7
test(backend): make the glob regression check Windows-safe
JohnMcLear May 17, 2026
5910b62
test(backend): use path.relative for cross-platform glob normalization
JohnMcLear May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/tests/backend-new/specs/backend-tests-glob.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,20 @@

import {execFileSync} from 'child_process';
import {readFileSync} from 'fs';
import {join} from 'path';
import {isAbsolute, join, relative} from 'path';
import {describe, it, expect} from 'vitest';

const srcRoot = join(__dirname, '..', '..', '..');
const pkg = JSON.parse(readFileSync(join(srcRoot, 'package.json'), 'utf8'));

// Strip `cross-env NAME=value` prefixes and the leading binary name so we
// can pass the remaining tokens straight to npx mocha --dry-run.
// invoke mocha directly with the rest of the script's arguments.
const tokens = String(pkg.scripts.test).split(/\s+/);
while (tokens[0] && /^[A-Z_][A-Z0-9_]*=/.test(tokens[0])) tokens.shift();
if (tokens[0] === 'cross-env') {
tokens.shift();
while (tokens[0] && /^[A-Z_][A-Z0-9_]*=/.test(tokens[0])) tokens.shift();
}
// Drop the binary itself (mocha) — npx will re-add it.
if (tokens[0] === 'mocha') tokens.shift();

const REQUIRED = [
Expand All @@ -38,15 +37,26 @@ const REQUIRED = [

describe('backend test glob', () => {
it('discovers nested specs under tests/backend/specs/{api,admin}/', () => {
// Resolve mocha's JS entry directly and run it under the current node.
// Going through `npx` (or even via the package.json bin shim) breaks on
// Windows runners where the resolver doesn't auto-pick `.cmd`/`.bat`.
const mochaBin = require.resolve('mocha/bin/mocha.js');
const out = execFileSync(
'npx', ['mocha', '--dry-run', '--list-files', ...tokens],
process.execPath, [mochaBin, '--dry-run', '--list-files', ...tokens],
{cwd: srcRoot, encoding: 'utf8', env: {...process.env, NODE_ENV: 'production'}},
);
// mocha --list-files prints absolute paths. Normalise to repo-relative.
const seen = out.split('\n')
// mocha --list-files prints absolute paths with platform separators.
// Normalise to repo-relative POSIX paths so the assertions match on
// both Linux and Windows runners. path.relative handles drive-letter
// casing and mixed separators consistently; absolute lines that fall
// outside srcRoot (shouldn't happen with --recursive on srcRoot, but
// be defensive) are passed through untouched and would fail the
// toContain() check loudly rather than silently.
const seen = out.split(/\r?\n/)
.map((l) => l.trim())
.filter(Boolean)
.map((l) => l.replace(`${srcRoot}/`, ''));
.map((l) => (isAbsolute(l) ? relative(srcRoot, l) : l))
.map((l) => l.split(/[\\/]/).join('/'));
for (const required of REQUIRED) {
expect(seen, `mocha test glob missed ${required}`).toContain(required);
}
Expand Down
Loading