Integrate instruction matching tool#120
Open
mininny wants to merge 2 commits into
Open
Conversation
mininny
force-pushed
the
feature/mininny/integrate-instruction-matching-tool
branch
6 times, most recently
from
54a1164 to
4e74e4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 27 27
Lines 4126 4126
=======================================
Hits 2553 2553
Misses 1432 1432
Partials 141 141 ☔ View full report in Codecov by Sentry. |
mininny
force-pushed
the
feature/mininny/integrate-instruction-matching-tool
branch
9 times, most recently
from
f2bd974 to
8fa6c0d
Compare
mininny
force-pushed
the
feature/mininny/integrate-instruction-matching-tool
branch
from
8fa6c0d to
4f45fbd
Compare
mininny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates riscv64 instruction matching tool. Because all of the instruction used in Kona should be supported by Asterisc for a thorough FPVM implementation, we should check that there are no missing instruction in Asterisc vm implementation.
The new CircleCI workflow
instruction_checkcheckouts the asterisc repo and kona repo, and builds kona elf for riscv64, and checks in against the json file that contains instructions that asterisc supports. This list of instructions needs to be updated by hand when the implementation of RISCV VM is changed.