fix(_config.yml): scope eip layout to ERCS/ path#1760
Open
0xAxiom wants to merge 2 commits into
Open
Conversation
Closes ethereum#1759. The Jekyll defaults entry was scoped to path "EIPS", which never matched because proposals in this repo live under ERCS/. Result: every ERC page rendered with the bare Minima theme — no preamble table, no Authors field, no auto-generated Table of Contents. Fix: change path to "ERCS" so the eip layout applies to all ERC pages.
Collaborator
File
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1759.
Problem
The Jekyll
defaultsentry in_config.ymlwas scoped topath: "EIPS", which never matches because proposals in this repo live underERCS/. Every ERC page therefore rendered with the bare Minima theme — no preamble table, no Authors/Created fields, no auto-generated Table of Contents.The same proposals on the EIPs site render correctly because
ethereum/EIPshas the matching path.Fix
One character change:
path: "EIPS"→path: "ERCS". This makes theeiplayout apply to all ERC pages as intended.Before / After
ercs.ethereum.org/ERCS/erc-8004eiplayout with preamble + TOCercs.ethereum.org/ERCS/erc-8257eiplayout with preamble + TOC