Update ERC-7730: Introduce string internationalization process#1783
Open
forshtat wants to merge 2 commits into
Open
Update ERC-7730: Introduce string internationalization process#1783forshtat wants to merge 2 commits into
forshtat wants to merge 2 commits into
Conversation
Collaborator
File
|
|
The commit 5768fe2 (as a parent of 7d61b0d) contains errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am worried that leaving internationalization to be an afterthought in a Clear Signing protocol is too risky.
Once the standard is adopted in its English-only version, it may be very hard to move the needle and get hardware wallets to update their implementation to address less lucrative markets.
The proposal seems to me to be quite primitive, with a JSON translation files being linked directly from the core ERC-7730 spec.
I am not a professional internationalization expert and would love to hear feedback on how this may be further improved or optimized.