Update ERC-7730: Introduce support for provisioning and annotation for contract storage layout data#1784
Draft
forshtat wants to merge 3 commits into
Draft
Update ERC-7730: Introduce support for provisioning and annotation for contract storage layout data#1784forshtat wants to merge 3 commits into
forshtat wants to merge 3 commits into
Conversation
Collaborator
File
|
|
The commit 4ef6363 (as a parent of 70d1809) contains errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to display the Transaction Outcome Simulation results (and Transaction Assertions) in the trusted (hardware) wallet UI, the wallet needs to trust the simulation provider to supply the correct simulation results data.
In my opinion, it is not optimal to also trust the simulation provider with parsing the contracts' storage layout and interpreting the simulated state changes to the user.
I see the annotated storage layout as a part of the contract's static data similar to the calldata inputs and belongs in ERC-7730 registry.
This PR is still WIP.