-
Notifications
You must be signed in to change notification settings - Fork 214
Reflect recent update to gloas specs #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||
| Gloas: | ||||||
| ExecutionPayload: | ||||||
| description: "The [`ExecutionPayload`](https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.8/specs/gloas/beacon-chain.md#executionpayload) object from the CL Gloas spec." | ||||||
| allOf: | ||||||
| - $ref: "../deneb/execution_payload.yaml#/Deneb/ExecutionPayload" | ||||||
| - type: object | ||||||
| required: [block_access_list, slot_number] | ||||||
| properties: | ||||||
| block_access_list: | ||||||
| type: string | ||||||
| format: hex | ||||||
| description: "RLP encoded `BlockAccessList` as defined in [EIP-7928]" | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this supposed to have a link to the EIP?
Suggested change
|
||||||
| pattern: "^0x[a-fA-F0-9]{0,2147483648}$" | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. might be good to also add an example above eg. |
||||||
| slot_number: | ||||||
| $ref: "../primitive.yaml#/Uint64" | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,6 +66,12 @@ Root: | |
| example: "0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2" | ||
| pattern: "^0x[a-fA-F0-9]{64}$" | ||
|
|
||
| Hash32: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure if we want this, or we can just use But I also see
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its differentiated in the spec, so it might make it cleaner to have hash32 defined here too. fair call imo.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am fine with adding |
||
| type: string | ||
| format: hex | ||
| example: "0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2" | ||
| pattern: "^0x[a-fA-F0-9]{64}$" | ||
|
|
||
| Bytes32: | ||
| type: string | ||
| format: hex | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,3 +45,4 @@ ptc | |
| PtcDuty | ||
| produceBlockV | ||
| stateful | ||
| RLP | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good if we can bump all spec references to
v1.7.0-alpha.8that currently reference an older alpha.x release