Add SSZ support to register validator api#110
Merged
Conversation
2 tasks
jtraglia
reviewed
Feb 5, 2025
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
This was referenced Feb 10, 2025
jtraglia
approved these changes
Feb 19, 2025
4 tasks
3 tasks
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
May 8, 2025
**Motivation** See ethereum/builder-specs#110 **Description** Send validator registrations to builder using SSZ **TODO** - [x] make sure all mev sidecars support 415 status code to fall back to JSON or add custom retry mechanism - [x] ~~forward bytes submitted through [registerValidator](https://ethereum.github.io/beacon-APIs/#/Validator/registerValidator) beacon api to skip extra serialization step~~ cannot be done right now since we are filtering registrations [here](https://github.com/ChainSafe/lodestar/blob/0463a14aa47171063aa5fb5452db6a91bcd7e59a/packages/beacon-node/src/api/impl/validator/index.ts#L1544) so forwarding raw SSZ bytes is not an option and extra work is likely not worth it as serialization is cheap anyways when using SSZ Closes #7369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #104 to also add SSZ support to
registerValidatorapi, which should help in cases where the validator client runs a lot of keys and reduce amount of failed requests.Since we can't really know if the server supports sending the validator registration as SSZ encoded payload the client will be responsible to retry the request using JSON which ideally should only be done if the error status code is 415, indicating an unsupported media type, but since right now we don't really know if all servers properly follow the spec, it is recommended to retry all HTTP errors and after the first error, the client should stop sending SSZ encoded validator registrations.