Skip to content

Add new MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS preset #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtraglia wants to merge 2 commits into from
Closed

Add new MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS preset #5224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b266176
Add new `MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS` preset
jtraglia May 8, 2026
97b826d
Set value to 2**20 (1 million)
jtraglia May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions presets/mainnet/gloas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ BUILDER_REGISTRY_LIMIT: 1099511627776
# 2**20 (= 1,048,576) builder pending withdrawals
BUILDER_PENDING_WITHDRAWALS_LIMIT: 1048576

# Execution
# ---------------------------------------------------------------
# 2**20 (= 1,048,576) deposit requests
MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS: 1048576

# Withdrawals processing
# ---------------------------------------------------------------
# 2**14 (= 16,384) builders
Expand Down
5 changes: 5 additions & 0 deletions presets/minimal/gloas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ BUILDER_REGISTRY_LIMIT: 1099511627776
# 2**20 (= 1,048,576) builder pending withdrawals
BUILDER_PENDING_WITHDRAWALS_LIMIT: 1048576

# Execution
# ---------------------------------------------------------------
# 2**20 (= 1,048,576) deposit requests
MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS: 1048576

# Withdrawals processing
# ---------------------------------------------------------------
# [customized] 2**4 (= 16) builders
Expand Down
18 changes: 18 additions & 0 deletions specs/gloas/beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- [Misc](#misc-1)
- [Max operations per block](#max-operations-per-block)
- [State list lengths](#state-list-lengths)
- [Execution](#execution)
- [Withdrawals processing](#withdrawals-processing)
- [Configuration](#configuration)
- [Validator cycle](#validator-cycle)
Expand All @@ -33,6 +34,7 @@
- [`ExecutionPayloadEnvelope`](#executionpayloadenvelope)
- [`SignedExecutionPayloadEnvelope`](#signedexecutionpayloadenvelope)
- [Modified containers](#modified-containers)
- [`ExecutionRequests`](#executionrequests)
- [`BeaconBlockBody`](#beaconblockbody)
- [`BeaconState`](#beaconstate)
- [`ExecutionPayload`](#executionpayload)
Expand Down Expand Up @@ -179,6 +181,12 @@ Gloas is a consensus-layer upgrade containing a number of features. Including:
| `BUILDER_REGISTRY_LIMIT` | `uint64(2**40)` (= 1,099,511,627,776) | Builders |
| `BUILDER_PENDING_WITHDRAWALS_LIMIT` | `uint64(2**20)` (= 1,048,576) | Builder pending withdrawals |

### Execution

| Name | Value | Description |
| ---------------------------------------- | ----------------------------- | ------------------------------------------------------------------ |
| `MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS` | `uint64(2**20)` (= 1,048,576) | Maximum number of execution-layer deposit requests in each payload |

@mkalinin mkalinin May 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the comment that effectively it means constraining by the gas limit?


### Withdrawals processing

| Name | Value |
Expand Down Expand Up @@ -318,6 +326,16 @@ class SignedExecutionPayloadEnvelope(Container):

### Modified containers

#### `ExecutionRequests`

```python
class ExecutionRequests(Container):
# [Modified in Gloas]
deposits: List[DepositRequest, MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS]
withdrawals: List[WithdrawalRequest, MAX_WITHDRAWAL_REQUESTS_PER_PAYLOAD]
consolidations: List[ConsolidationRequest, MAX_CONSOLIDATION_REQUESTS_PER_PAYLOAD]
```

#### `BeaconBlockBody`

*Note*: The removed fields (`execution_payload`, `blob_kzg_commitments`, and
Expand Down
50 changes: 50 additions & 0 deletions specs/gloas/validator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- [Constructing the `PayloadAttestationMessage`](#constructing-the-payloadattestationmessage)
- [Modified functions](#modified-functions)
- [Modified `get_data_column_sidecars_from_column_sidecar`](#modified-get_data_column_sidecars_from_column_sidecar)
- [Modified `get_execution_requests`](#modified-get_execution_requests)

<!-- mdformat-toc end -->

Expand Down Expand Up @@ -381,3 +382,52 @@ def get_data_column_sidecars_from_column_sidecar(
cells_and_kzg_proofs,
)
```

### Modified `get_execution_requests`

```python
def get_execution_requests(execution_requests_list: Sequence[bytes]) -> ExecutionRequests:
deposits = []
withdrawals = []
consolidations = []

request_types = [
DEPOSIT_REQUEST_TYPE,
WITHDRAWAL_REQUEST_TYPE,
CONSOLIDATION_REQUEST_TYPE,
]

prev_request_type = None
for request in execution_requests_list:
request_type, request_data = request[0:1], request[1:]

# Check that the request type is valid
assert request_type in request_types
# Check that the request data is not empty
assert len(request_data) != 0
# Check that requests are in strictly ascending order
# Each successive type must be greater than the last with no duplicates
assert prev_request_type is None or prev_request_type < request_type
prev_request_type = request_type

if request_type == DEPOSIT_REQUEST_TYPE:
deposits = ssz_deserialize(
# [Modified in Gloas]
List[DepositRequest, MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS],
request_data,
)
elif request_type == WITHDRAWAL_REQUEST_TYPE:
withdrawals = ssz_deserialize(
List[WithdrawalRequest, MAX_WITHDRAWAL_REQUESTS_PER_PAYLOAD], request_data
)
elif request_type == CONSOLIDATION_REQUEST_TYPE:
consolidations = ssz_deserialize(
List[ConsolidationRequest, MAX_CONSOLIDATION_REQUESTS_PER_PAYLOAD], request_data
)

return ExecutionRequests(
deposits=deposits,
withdrawals=withdrawals,
consolidations=consolidations,
)
```
4 changes: 2 additions & 2 deletions .../eth_consensus_specs/test/gloas/block_processing/test_process_parent_execution_payload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def test_process_parent_execution_payload__full_parent_with_execution_requests(s
unknown pubkeys are no-ops.
"""
requests = spec.ExecutionRequests(
deposits=spec.List[spec.DepositRequest, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD](
deposits=spec.List[spec.DepositRequest, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS](
[
spec.DepositRequest(
pubkey=spec.BLSPubkey(b"\x01" * 48),
Expand Down Expand Up @@ -333,7 +333,7 @@ def test_process_parent_execution_payload__builder_deposit_after_pending_validat
)

requests = spec.ExecutionRequests(
deposits=spec.List[spec.DepositRequest, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD](
deposits=spec.List[spec.DepositRequest, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS](
[deposit_request_1, deposit_request_2]
),
withdrawals=spec.List[spec.WithdrawalRequest, spec.MAX_WITHDRAWAL_REQUESTS_PER_PAYLOAD](),
Expand Down
2 changes: 1 addition & 1 deletion ...e/pyspec/eth_consensus_specs/test/gloas/fork_choice/test_on_execution_payload_envelope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def test_on_execution_payload_envelope__wrong_execution_requests_root(spec, stat

# Build envelope with non-empty requests but bid commits to empty requests
non_empty_requests = spec.ExecutionRequests(
deposits=spec.List[spec.DepositRequest, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD](
deposits=spec.List[spec.DepositRequest, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS](
[
spec.DepositRequest(
pubkey=spec.BLSPubkey(b"\x01" * 48),
Expand Down
8 changes: 7 additions & 1 deletion tests/core/pyspec/eth_consensus_specs/test/helpers/execution_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from eth_consensus_specs.test.helpers.deposits import prepare_deposit_request
from eth_consensus_specs.test.helpers.forks import is_post_gloas


def get_non_empty_execution_requests(spec):
Expand All @@ -10,8 +11,13 @@ def get_non_empty_execution_requests(spec):
signed=False,
)

if is_post_gloas(spec):
max_deposit_requests_per_payload = spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD_GLOAS
else:
max_deposit_requests_per_payload = spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD

return spec.ExecutionRequests(
deposits=spec.List[spec.DepositRequest, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD](
deposits=spec.List[spec.DepositRequest, max_deposit_requests_per_payload](
[deposit_request]
),
withdrawals=spec.List[spec.WithdrawalRequest, spec.MAX_WITHDRAWAL_REQUESTS_PER_PAYLOAD](),
Expand Down
6 changes: 4 additions & 2 deletions tests/core/pyspec/eth_consensus_specs/test/helpers/multi_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
)
from eth_consensus_specs.test.helpers.bls_to_execution_changes import get_signed_address_change
from eth_consensus_specs.test.helpers.deposits import build_deposit, deposit_from_context
from eth_consensus_specs.test.helpers.forks import is_post_electra
from eth_consensus_specs.test.helpers.forks import is_post_electra, is_post_gloas
from eth_consensus_specs.test.helpers.keys import privkeys, pubkeys
from eth_consensus_specs.test.helpers.proposer_slashings import get_valid_proposer_slashing
from eth_consensus_specs.test.helpers.state import (
Expand Down Expand Up @@ -299,7 +299,9 @@ def get_random_execution_requests(spec, state, rng):

def get_random_deposit_requests(spec, state, rng, num_deposits=None):
if num_deposits is None:
num_deposits = rng.randint(0, spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD)
# Use an arbitrarily high number for gloas+
limit = spec.MAX_DEPOSIT_REQUESTS_PER_PAYLOAD if is_post_gloas(spec) else 10000
num_deposits = rng.randint(0, limit)

deposit_data_leaves = [spec.DepositData() for _ in range(len(state.validators))]

Expand Down