Use should_build_on_full for bid parent block hash#5310
Conversation
|
|
||
| #### Constructing the `BeaconBlockBody` | ||
|
|
||
| Let `head = get_head(store)` be the parent block the proposer is building on, |
There was a problem hiding this comment.
we might wanna use get_proposer_head here cc @michaelsproul
There was a problem hiding this comment.
@jtraglia we can't use get_proposer_head because it returns Root and not ForkChoiceNode, but we can make that change separate from this PR which makes it just a 1-line change later
There was a problem hiding this comment.
Sounds good. I'm going to merge this now & let you make the follow up PR.
There was a problem hiding this comment.
let you make the follow up PR.
you mean the ForkChoiceNode refactor? no idea what's the effort for this or how to do it correctly as I haven't look into that but seems same refactoring we wanna do to FCR cc @mkalinin
in any case, there is no rush to do this, our implementation uses get_proposer_head already and I suspect all other clients that implement proposer boost reorg do too
There was a problem hiding this comment.
Hmm okay. So we should merge this PR & deal with the refactor after the release?
There was a problem hiding this comment.
I don't see how it matters for the release, we can even use get_proposer_head already, I don't think the linter catches this?
4 participants
seems like this was missed in #5186