Add Gloas test for get_attestation_participation_flag_indices#5341
Open
brech1 wants to merge 2 commits into
Open
Add Gloas test for get_attestation_participation_flag_indices#5341brech1 wants to merge 2 commits into
get_attestation_participation_flag_indices#5341brech1 wants to merge 2 commits into
Conversation
brech1
force-pushed
the
test/process-attestation-same-slot
branch
from
64b884f to
de917b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test for the Gloas same-slot path in
get_attestation_participation_flag_indices, wherepayload_matchesis set toTrueregardless ofexecution_payload_availability.It also removes three tests that didn't correctly cover the rule they had to.
Changes
test_same_slot_attestation_ignores_payload_availability.test_matching_payload_true_same_slot: availability anddata.indexwere both0, so a broken comparison would still returnTrue.test_matching_payload_true_historical_slot: the attestation was included too late forTIMELY_HEAD_FLAG_INDEXto ever be set, so the head-flag assertion could not fail.test_matching_payload_false_historical_slot: thebeacon_block_rootdid not match the head root, so the head flag was already off.test_mismatched_payload_no_head_flagalready covers this case cleanly.