Set altair/bellatrix fork epochs to zero in BTEC gossip tests#5346
Open
jtraglia wants to merge 4 commits into
Open
Set altair/bellatrix fork epochs to zero in BTEC gossip tests#5346jtraglia wants to merge 4 commits into
jtraglia wants to merge 4 commits into
Conversation
nflaig
reviewed
Jun 8, 2026
| { | ||
| "ALTAIR_FORK_EPOCH": 0, | ||
| "BELLATRIX_FORK_EPOCH": 0, | ||
| "CAPELLA_FORK_EPOCH": 0, |
Member
There was a problem hiding this comment.
this list can become pretty large for later forks, maybe we can have an ordered list of forks in the spec helpers and pick the highest fork for epoch (in this case 0)? That's more or less how we do it in lodestar, so you don't need to set earlier fork epochs explicitly
Member
Author
There was a problem hiding this comment.
Ah wait. You just made me realize this solution is incomplete. Are you suggesting we do this ("maybe we can have an ordered list of forks in the spec helpers") here in the specs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
bls_to_execution_changegossip validation tests, we setCAPELLA_FORK_EPOCHto a non-FAR_FUTURE_EPOCHvalue but leave the previous fork epochs as-is. This is confusing for implementations since the capella epoch is lower. Let's hardcode the previous fork epochs to zero.