Modify get_proposer_head for Gloas#5348
Open
jihoonsong wants to merge 6 commits into
Open
Conversation
This was referenced Jun 8, 2026
jihoonsong
force-pushed
the
get-proposer-head-gloas
branch
from
66ed985 to
24a68ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
get_proposer_headfor Gloas. It changes its signature to receives and returns ForkChoiceNode. Relevant comments are changed accordingly.Additionally, this PR fixes the issue stated in #5305. It changes
is_parent_strongto consider the PENDING parent node to count support for the parent node regardless of its payload status.cc @mkalinin @michaelsproul