feat(spec-specs, tests): 8037 2d edge cases

Author: kclowes

tests/amsterdam/eip8037_state_creation_gas_cost_increase/test_block_2d_gas_accounting.py

@@ -515,6 +515,52 @@ def test_tx_rejected_when_regular_gas_exceeds_block_limit_small(
     )
 
 
+@pytest.mark.valid_from("EIP8037")
+def test_tx_accepted_when_regular_gas_exactly_fits_block_limit_small(
+    blockchain_test: BlockchainTestFiller,
+    pre: Alloc,
+    fork: Fork,
+) -> None:
+    """
+    Accept a small-gas tx whose regular gas exactly fits the block.
+
+    Boundary counterpart to
+    ``test_tx_rejected_when_regular_gas_exceeds_block_limit_small``.
+    The second tx's gas_limit equals the remaining regular budget
+    exactly. The inclusion check uses strict ``>``, so equal must
+    pass. Catches an off-by-one ``>=`` bug.
+    """
+    intrinsic_gas = fork.transaction_intrinsic_cost_calculator()()
+
+    block_gas_limit = intrinsic_gas * 2
+
+    filler = pre.deploy_contract(code=Op.STOP)
+    filler_tx = Transaction(
+        to=filler,
+        gas_limit=intrinsic_gas,
+        sender=pre.fund_eoa(),
+    )
+
+    accepted = pre.deploy_contract(code=Op.STOP)
+    accepted_tx = Transaction(
+        to=accepted,
+        gas_limit=intrinsic_gas,
+        sender=pre.fund_eoa(),
+    )
+
+    blockchain_test(
+        genesis_environment=Environment(gas_limit=block_gas_limit),
+        pre=pre,
+        blocks=[
+            Block(
+                txs=[filler_tx, accepted_tx],
+                gas_limit=block_gas_limit,
+            )
+        ],
+        post={},
+    )
+
+
 @pytest.mark.parametrize(
     "tx2_gas_limit_equals_block_gas_limit",
     [

tests/amsterdam/eip8037_state_creation_gas_cost_increase/test_state_gas_create.py

@@ -27,6 +27,7 @@
     Storage,
     Transaction,
     TransactionException,
+    TransactionReceipt,
     compute_create_address,
 )
 from execution_testing.checklists import EIPChecklist
@@ -1585,6 +1586,57 @@ def test_failed_create_tx_state_gas_dominates(
     )
 
 
+@pytest.mark.parametrize(
+    "failure_mode",
+    [
+        pytest.param("revert", id="revert"),
+        pytest.param("halt", id="halt"),
+    ],
+)
+@pytest.mark.valid_from("EIP8037")
+def test_failed_create_tx_sender_billing(
+    state_test: StateTestFiller,
+    pre: Alloc,
+    fork: Fork,
+    failure_mode: str,
+) -> None:
+    """
+    Verify sender billing for a failed creation tx with tight gas.
+
+    Complements ``test_failed_create_tx_state_gas_dominates`` which
+    checks the header. This pins ``cumulative_gas_used`` to verify
+    the execution state gas refund reaches the sender.
+    """
+    intrinsic_calc = fork.transaction_intrinsic_cost_calculator()
+
+    if failure_mode == "revert":
+        init_code = Op.REVERT(0, 0)
+    else:
+        init_code = Op.INVALID
+
+    intrinsic_total = intrinsic_calc(
+        calldata=bytes(init_code), contract_creation=True
+    )
+    gas_limit = intrinsic_total + 1000
+
+    if failure_mode == "revert":
+        expected_cumulative = intrinsic_total + init_code.gas_cost(fork)
+    else:
+        expected_cumulative = gas_limit
+
+    tx = Transaction(
+        to=None,
+        data=init_code,
+        gas_limit=gas_limit,
+        sender=pre.fund_eoa(),
+        expected_receipt=TransactionReceipt(
+            cumulative_gas_used=expected_cumulative,
+        ),
+    )
+
+    state_test(pre=pre, post={}, tx=tx)
+
+
 @pytest.mark.parametrize(
     "initcode_size_delta",
     [