Skip to content

Speed-up bench-gas check #2673

@danceratopz

Description

@danceratopz

Currently, the just bench-gas check is the bottleneck in CI at 18 minutes.

One possible solution is to reduce the --gas-benchmark-values flag from 1.0 to 0.5 (or even 0.2)? Perhaps this causes problems with tests, we should try it.

Currently, changing this results in this pydantic validation error:

INTERNALERROR> pydantic_core._pydantic_core.ValidationError: 1 validation error for GasBenchmarkValues
INTERNALERROR> 0
INTERNALERROR>   Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='0.5', input_type=str]
INTERNALERROR>     For further information visit https://errors.pydantic.dev/2.12/v/int_parsing

which can fix by changing the type from int to float > 0.001 (or something else more reasonable) - this flag is measured in Mgas.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ciArea: Continuous IntegrationA-test-benchmarkArea: execution_testing.benchmark and tests/benchmarkA-toolingArea: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ...E-easyExperience: easy, good for newcomersP-high

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions