-
Notifications
You must be signed in to change notification settings - Fork 450
Speed-up bench-gas check #2673
Copy link
Copy link
Open
Labels
A-ciArea: Continuous IntegrationArea: Continuous IntegrationA-test-benchmarkArea: execution_testing.benchmark and tests/benchmarkArea: execution_testing.benchmark and tests/benchmarkA-toolingArea: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ...Area: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ...E-easyExperience: easy, good for newcomersExperience: easy, good for newcomersP-high
Metadata
Metadata
Assignees
Labels
A-ciArea: Continuous IntegrationArea: Continuous IntegrationA-test-benchmarkArea: execution_testing.benchmark and tests/benchmarkArea: execution_testing.benchmark and tests/benchmarkA-toolingArea: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ...Area: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ...E-easyExperience: easy, good for newcomersExperience: easy, good for newcomersP-high
Currently, the
just bench-gascheck is the bottleneck in CI at 18 minutes.One possible solution is to reduce the
--gas-benchmark-valuesflag from1.0to0.5(or even0.2)? Perhaps this causes problems with tests, we should try it.Currently, changing this results in this pydantic validation error:
which can fix by changing the type from int to float > 0.001 (or something else more reasonable) - this flag is measured in Mgas.