fix(testing): record converged gas optimization limit#2671
Open
RekCuy63 wants to merge 1 commit intoethereum:forks/amsterdamfrom
Open
fix(testing): record converged gas optimization limit#2671RekCuy63 wants to merge 1 commit intoethereum:forks/amsterdamfrom
RekCuy63 wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2671 +/- ##
================================================
Coverage 86.25% 86.25%
================================================
Files 599 599
Lines 37032 37032
Branches 3795 3795
================================================
Hits 31943 31943
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The gas optimization binary search already verifies the converged value with
minimum_gas_limit, but the recordedgas_optimizationfield still used the last loop-localcurrent_gas_limit.When the final probe is a failing candidate, this stores a value that is one step below the actual minimum gas limit and propagates the wrong optimization result to the JSON output used by follow-up analysis.
This PR records
minimum_gas_limitafter convergence and adds a regression test to lock in the expected bookkeeping behavior.🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture