Skip to content

fix(benchmarks): fix test_sload_bloated_prefetch_miss and test_sload_bloated_multi_contract in execute remote filler#2688

Draft
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
jochem-brouwer:hotfix-prefetch-trick
Draft

fix(benchmarks): fix test_sload_bloated_prefetch_miss and test_sload_bloated_multi_contract in execute remote filler#2688
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
jochem-brouwer:hotfix-prefetch-trick

Conversation

@jochem-brouwer
Copy link
Copy Markdown
Member

🗒️ Description

This PR resolves problems filling the tests and hacks in a EIP-7702 deployer to target 20GB bloated contract instead of empty contract. test_sload_bloated_prefetch_miss or test_sload_bloated_multi_contract have to be solved, multi_contract not yet solved this has initcode too large for the storage set.

The EOA generator seems to cause an issue where "Sender balance must be set before sending" is thrown, seems to have to do with EOA screated which do not send txs.

These are not problems in fill mode, but these are in execute remote world, which stresses at some point we should get CI to check these.

Note: For test_sload_bloated_prefetch_miss there were certain gas limits which have failures, like 60M, this fails FAILED tests/benchmark/stateful/bloatnet/test_single_opcode.py::test_sload_bloated_prefetch_miss[1GB-fork_Amsterdam-benchmark_test-existing_slots_True-distinct_senders_False-benchmark-gas-value_60M] and then eest_stateful_generator.py OR EEST just hangs 🤔

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant