fix(benchmarks): fix test_sload_bloated_prefetch_miss and test_sload_bloated_multi_contract in execute remote filler#2688
Draft
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR resolves problems filling the tests and hacks in a EIP-7702 deployer to target 20GB bloated contract instead of empty contract.
test_sload_bloated_prefetch_miss or test_sload_bloated_multi_contracthave to be solved, multi_contract not yet solved this has initcode too large for the storage set.The EOA generator seems to cause an issue where "Sender balance must be set before sending" is thrown, seems to have to do with EOA screated which do not send txs.
These are not problems in fill mode, but these are in execute remote world, which stresses at some point we should get CI to check these.
Note: For test_sload_bloated_prefetch_miss there were certain gas limits which have failures, like 60M, this fails
FAILED tests/benchmark/stateful/bloatnet/test_single_opcode.py::test_sload_bloated_prefetch_miss[1GB-fork_Amsterdam-benchmark_test-existing_slots_True-distinct_senders_False-benchmark-gas-value_60M]and then eest_stateful_generator.py OR EEST just hangs 🤔🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture