Skip to content

fix spurious formatting diffs from gas constants refactor#2699

Open
knQzx wants to merge 61 commits intoethereum:forks/amsterdamfrom
knQzx:fix-spurious-diffs-2396
Open

fix spurious formatting diffs from gas constants refactor#2699
knQzx wants to merge 61 commits intoethereum:forks/amsterdamfrom
knQzx:fix-spurious-diffs-2396

Conversation

@knQzx
Copy link
Copy Markdown
Contributor

@knQzx knQzx commented Apr 16, 2026

Fixes #2681

Depends on #2396

Summary

  • Aligns word wrapping in check_gas_limit docstrings across all fork fork.py files
  • PR refactor(spec-specs): add opcode gas constants #2396 rewrapped the docstring text in some forks (amsterdam, berlin, frontier, istanbul, muir_glacier, osaka, prague, bpo1-5) but left the old wrapping in others (arrow_glacier, byzantium, cancun, constantinople, dao_fork, gray_glacier, homestead, london, paris, shanghai, spurious_dragon, tangerine_whistle)
  • This applies the same rewrapping to the 12 forks that were missed, making the formatting consistent

Test plan

  • No functional changes, only docstring word wrapping
  • Verified all 24 forks now have identical docstring text
  • All lines are within the 79-character line length limit

@Carsons-Eels
refactor(spec-specs): add opcode gas constants
ad2816f
@Carsons-Eels
refactor(spec-specs): renamed GAS_BLOBHASH_OPCODE to GAS_BLOBHASH to …
3c81ee4 
…more clearly differentiate between intermediate constants and existing ones
@Carsons-Eels
refactor(testing): add per-opcode gas constants to GasCosts
78aa88b 
Add 39 GAS_OPCODE_* fields to the GasCosts dataclass and update
opcode_gas_map() in all forks to reference per-opcode fields
instead of shared tier constants.
@Carsons-Eels
refactor: move post-frontier opcodes
30fb2ae
@Carsons-Eels
refactor: added gas tiers for the test code
76d6201
@Carsons-Eels
refactor: use gas module refs for opcode constants
9adbb1a
@Carsons-Eels
refactor: correct GAS_OPCODE_DUP_N to GAS_OPCODE_DUP
14e72c2
@Carsons-Eels
refactor: correct GAS_OPCODE_SWAP_N to GAS_OPCODE_SWAP
26304a7
@Carsons-Eels
fix: static checks
ec3255d
@Carsons-Eels
refactor: amsterdam conversion to encapsulate Gas Constants in class
82f1bcc
@Carsons-Eels
refactor: frontier conversion to encapsulate Gas Constants in class
4e205e5
@Carsons-Eels
refactor: berlin conversion to encapsulate Gas Constants in class
49af689
@Carsons-Eels
refactor: byzantium conversion to encapsulate Gas Constants in class
a6fc233
@Carsons-Eels
refactor: cancun conversion to encapsulate Gas Constants in class
0721da3
@Carsons-Eels
refactor: constantinople conversion to encapsulate Gas Constants in c…
5ed355d 
…lass
@Carsons-Eels
refactor: fix bad spelling of Belrin (Berlin)
e93dea3
@Carsons-Eels
refactor: homestead and dao conversion to encapsulate Gas Constants i…
4ba5545 
…n class
@Carsons-Eels
refactor: tangerine_whistle conversion to encapsulate Gas Constants i…
7a4f16b 
…n class
@Carsons-Eels
refactor: spurious_dragon conversion to encapsulate Gas Constants in …
f47f46f 
…class
@Carsons-Eels
refactor: istanbul and muir glacier conversion to encapsulate Gas Con…
f0bb696 
…stants in class
@Carsons-Eels
refactor: london, arrow glacier, and muir glacier conversion to encap…
7f29c07 
…sulate Gas Constants in class
@Carsons-Eels
refactor: paris conversion to encapsulate Gas Constants in class
77228d2
@Carsons-Eels
refactor: shanghai conversion to encapsulate Gas Constants in class
e82d4ae
@Carsons-Eels
refactor: prague conversion to encapsulate Gas Constants in class
bc48f63
@Carsons-Eels
refactor: osaka conversion to encapsulate Gas Constants in class
59d7243
@Carsons-Eels
refactor: BPO1 conversion to encapsulate Gas Constants in class
19ef467
@Carsons-Eels
refactor: BPO2 conversion to encapsulate Gas Constants in class
4c14505
@Carsons-Eels
refactor: BPO3 conversion to encapsulate Gas Constants in class
98a5764
@Carsons-Eels
refactor: BPO4 conversion to encapsulate Gas Constants in class
84314aa
@Carsons-Eels
refactor: BPO5 conversion to encapsulate Gas Constants in class
eee2e5b
Carsons-Eels and others added 30 commits April 13, 2026 23:27
@Carsons-Eels
feat: add COINBASE opcode gas constant
290aa20
@Carsons-Eels
refactor: align formatting of a docstring
5f77a69
@Carsons-Eels
fix: code review comments
17da946
@Carsons-Eels
refactor:GAS_BLOCK_HASH => GAS_OPCODE_BLOCKHASH
246f14a
@Carsons-Eels
refactor:GAS_JUMPDEST => GAS_OPCODE_JUMPDEST
af420fa
@Carsons-Eels
refactor:GAS_BLOBHASH => GAS_OPCODE_BLOBHASH
9635725
@Carsons-Eels
refactor:GAS_OPCODE => OPCODE
13445c3
@Carsons-Eels
refactor: drop GAS_ prefix for opcode, precompile, and refund consts
5eb0f82
@Carsons-Eels
refactor: remove GAS_ prefix from remaining non-module-level constants
5a81fc1
@Carsons-Eels
refactor: group tier gas constants
cb1dfbd
@Carsons-Eels
refactor: remove GAS_ prefix in all test code + clean up
a235eb2
@Carsons-Eels
refactor: alt_bn128 now uses precompile gas constants in spec
215f4ae
@Carsons-Eels
reafactor(spec): reorganize gas.py, refactor two constant names
d14f63e
@Carsons-Eels
refactor: COPY=>OPCODE_COPY_PER_WORD
b5a013f
@Carsons-Eels
refactor: MEMORY=>MEMORY_PER_WORD
9e013e2
@Carsons-Eels
refactor: CREATE=>CREATE_BASE
250570b
@Carsons-Eels
refactor: EXPONENTIATION=>OPCODE_EXP_BASE, EXPONENTIATION_PER_BYTE OP…
b3a7d3a 
…CODE_EXP_PER_BYTE
@Carsons-Eels
refactor: KECCAK256=>OPCODE_KECCAK256_BASE, KECCAK256_PER_WORD=>OPCOD…
eec2354 
…E_KECCAK256_PER_WORD
@Carsons-Eels
refactor: KECCAK256=>OPCODE_KECCAK256_BASE, KECCAK256_PER_WORD=>OPCOD…
9a84b4f 
…E_KECCAK256_PER_WORD
@Carsons-Eels
refactor: SELF_DESTRUCT=>OPCODE_SELFDESTRUCT_BASE, SELF_DESTRUCT_NEW_…
ddd0db6 
…ACCOUNT=>OPCODE_SELF_DESTRUCT_NEW_ACCOUNT
@Carsons-Eels
refactor: forgot KECCAK256 and LOG in test code
4798b20
@Carsons-Eels
refactor: EXTERNAL=>OPCODE_EXTERNAL_BASE, BALANCE=>OPCODE_BALANCE
2237a87
@Carsons-Eels
refactor: added _BASE suffix to CALLDATACOPY, CODECOPY, MLOAD, MSTORE…
d7aca84 
…, MSTORE8
@Carsons-Eels
refactor: RETURN_DATA_COPY=>OPCODE_RETURNDATACOPY_PER_WORD
16fc81c
@Carsons-Eels
refactor: last few opcode refactors
184148b
@Carsons-Eels
fix: merge fixes
4dad95b
@Carsons-Eels
refactor: move transaction gas constatns with other gas constants for…
a6a5607 
… repricing mechanism.
@Carsons-Eels
refactor: add missing opcode gas constants and replace usage in funct…
235c510 
…ions
@Carsons-Eels
fix: cr comment misplacement
24762c1
@knQzx
fix spurious formatting diffs from gas constants refactor
e67820c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix spurious diffs introduced in #2396

2 participants

@knQzx @Carsons-Eels