fix(cli): add pytest EIP markers for valid_from tests#2701
Open
shrirajpawar4 wants to merge 2 commits intoethereum:forks/amsterdamfrom
Open
fix(cli): add pytest EIP markers for valid_from tests#2701shrirajpawar4 wants to merge 2 commits intoethereum:forks/amsterdamfrom
shrirajpawar4 wants to merge 2 commits intoethereum:forks/amsterdamfrom
Conversation
Author
|
@fselmo do take a look at PR whenever you can sir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Auto-add plain pytest
EIP####markers for tests that are explicitly enabled byvalid_from("EIP####").This makes EIP-scoped selection work as requested in #2675, so commands like:
uv run fill --clean --fork=Amsterdam -m EIP7928can select tests that are marked valid from a given EIP without relying on ad hoc -k expressions.
This change is intentionally narrow:
It also adds targeted regression tests covering:
🔗 Related Issues or PRs
Fixes #2675.
✅ Checklist
All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards (https://eest.ethereum.org/main/getting_started/code_standards/) and Enabling Pre-commit Checks
(https://eest.ethereum.org/main/dev/precommit/):
just static
All: PR title adheres to the repo standard (https://eest.ethereum.org/main/getting_started/contributing/?h=contri#commit-messages-issue-and-pr-titles) - it will be used as the squash commit mes
sage and should start type(scope):.
All: Considered updating the online docs in the /ethereum/execution-specs/blob/HEAD/docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference (https://eest.ethereum.org/main/tests/) are correctly formatted.
Tests: For PRs implementing a missed test case, update the /ethereum/execution-specs/blob/HEAD/docs/writing_tests/post_mortems.md to add an entry the list.
Ported Tests: All converted JSON/YML tests from /ethereum/tests or /ethereum/execution-specs/blob/HEAD/tests/static have been assigned @ported_from marker.
Verification
Manual behavior check against a real test file:
Observed result:
This confirms -m EIP7928 selects the valid_from("EIP7928") case and not the valid_before("EIP7928") case.
Targeted regression tests:
Observed result:
3 passed
Cute Animal Picture