Skip to content

fix(tooling): just static codespell finds 200+ typos for json_infra/fixtures, skip it#2706

Open
felix314159 wants to merge 1 commit intoethereum:forks/amsterdamfrom
felix314159:just-spellcheck
Open

fix(tooling): just static codespell finds 200+ typos for json_infra/fixtures, skip it#2706
felix314159 wants to merge 1 commit intoethereum:forks/amsterdamfrom
felix314159:just-spellcheck

Conversation

@felix314159
Copy link
Copy Markdown
Contributor

🗒️ Description

With the PR just static succeeds without issues

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@felix314159 felix314159 requested a review from spencer-tb April 17, 2026 10:06
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (40461a6) to head (d4a34ef).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2706   +/-   ##
================================================
  Coverage            86.26%   86.26%           
================================================
  Files                  599      599           
  Lines                37038    37038           
  Branches              3795     3795           
================================================
  Hits                 31949    31949           
  Misses                4525     4525           
  Partials               564      564           
Flag Coverage Δ
unittests 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pyproject.toml
"*.tar.gz",
"*.png",
"*/tests/fixtures",
"*/json_infra/fixtures",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had renamed json_infra to json_loader some time ago and we already have an entry to skip */json_loader/fixtures. I am wondering if this is a stale copy of json_infra on your local.

Copy link
Copy Markdown
Contributor

@fselmo fselmo Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I don't think we need this? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants