fix(tooling): just static codespell finds 200+ typos for json_infra/fixtures, skip it#2706
Open
felix314159 wants to merge 1 commit intoethereum:forks/amsterdamfrom
Open
fix(tooling): just static codespell finds 200+ typos for json_infra/fixtures, skip it#2706felix314159 wants to merge 1 commit intoethereum:forks/amsterdamfrom
just static codespell finds 200+ typos for json_infra/fixtures, skip it#2706felix314159 wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2706 +/- ##
================================================
Coverage 86.26% 86.26%
================================================
Files 599 599
Lines 37038 37038
Branches 3795 3795
================================================
Hits 31949 31949
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gurukamath
reviewed
Apr 21, 2026
| "*.tar.gz", | ||
| "*.png", | ||
| "*/tests/fixtures", | ||
| "*/json_infra/fixtures", |
Contributor
There was a problem hiding this comment.
I think we had renamed json_infra to json_loader some time ago and we already have an entry to skip */json_loader/fixtures. I am wondering if this is a stale copy of json_infra on your local.
Contributor
There was a problem hiding this comment.
Agreed, I don't think we need this? 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
With the PR
just staticsucceeds without issues🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture