chore(test-types): adds extra modifier validation; adds unit tests#2710
Open
fselmo wants to merge 3 commits intoethereum:forks/amsterdamfrom
Open
chore(test-types): adds extra modifier validation; adds unit tests#2710fselmo wants to merge 3 commits intoethereum:forks/amsterdamfrom
fselmo wants to merge 3 commits intoethereum:forks/amsterdamfrom
Conversation
ec3b5b4 to
2d2ec31
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2710 +/- ##
================================================
Coverage 86.26% 86.26%
================================================
Files 599 599
Lines 37038 37038
Branches 3795 3795
================================================
Hits 31949 31949
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…be `True` from an earlier call
Contributor
|
i think there is a state leak bug, added a test to show it. run with
feel free to fix |
felix314159
reviewed
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
From comment on EthR&D here, adds missing sanity check validations to BAL modifiers. These are currently not producing any errors but could allow some to slip through if not addressed.
✅ Checklist
just statictype(scope):.Cute Animal Picture