Skip to content

chore(test-types): adds extra modifier validation; adds unit tests#2710

Open
fselmo wants to merge 3 commits intoethereum:forks/amsterdamfrom
fselmo:chore/validate-modifiers
Open

chore(test-types): adds extra modifier validation; adds unit tests#2710
fselmo wants to merge 3 commits intoethereum:forks/amsterdamfrom
fselmo:chore/validate-modifiers

Conversation

@fselmo
Copy link
Copy Markdown
Contributor

@fselmo fselmo commented Apr 17, 2026

🗒️ Description

From comment on EthR&D here, adds missing sanity check validations to BAL modifiers. These are currently not producing any errors but could allow some to slip through if not addressed.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2026-04-17 at 09 54 37

@fselmo fselmo added C-chore Category: chore A-test-types Area: execution_testing.base_types and execution_testing.test_types labels Apr 17, 2026
@fselmo fselmo force-pushed the chore/validate-modifiers branch from ec3b5b4 to 2d2ec31 Compare April 17, 2026 16:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (c3462e0) to head (ba1ba1b).
⚠️ Report is 5 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2710   +/-   ##
================================================
  Coverage            86.26%   86.26%           
================================================
  Files                  599      599           
  Lines                37038    37038           
  Branches              3795     3795           
================================================
  Hits                 31949    31949           
  Misses                4525     4525           
  Partials               564      564           
Flag Coverage Δ
unittests 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felix314159
Copy link
Copy Markdown
Contributor

i think there is a state leak bug, added a test to show it. run with

uv run pytest packages/testing/src/execution_testing/test_types/tests/test_block_access_list_modifiers.py -v -s -k reused_callable

feel free to fix

Copy link
Copy Markdown
Contributor

@felix314159 felix314159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above, forgot to mark it as review comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-types Area: execution_testing.base_types and execution_testing.test_types C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants