feat(spec-specs, tests): 8037 more 2d edge cases#2735
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devnets/bal/7 #2735 +/- ##
================================================
Coverage ? 85.58%
================================================
Files ? 630
Lines ? 39600
Branches ? 3936
================================================
Hits ? 33891
Misses ? 5084
Partials ? 625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
de71eca to
f2049fb
Compare
638baf0 to
4dab63c
Compare
1b0780a to
6ac8e40
Compare
fselmo
reviewed
May 7, 2026
6ac8e40 to
1bcbc8d
Compare
Contributor
Author
|
@fselmo thank you! Rebased and combined. I'm not sure how much value the second test really adds any more, so happy to get rid of it, just lmk. Also switched one of the |
fselmo
approved these changes
May 8, 2026
fselmo
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just pushed the DRY refactor we chatted about 🚀
Contributor
Author
|
Changes LGTM! Thanks! |
spencer-tb
pushed a commit
to spencer-tb/execution-specs
that referenced
this pull request
May 22, 2026
* feat(spec-specs, tests): 8037 2d edge cases * refactor(tests): Combine almost duplicated tests * refactor(test): DRY - merge boundary tests together and parametrize --------- Co-authored-by: fselmo <fselmo2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
A couple more edge cases for the 2d gas calculation:
test_tx_accepted_when_regular_gas_exactly_fits_block_limit_small: Regular gas inclusion boundary: accept a tx whose regular gas exactly equals remaining block budget (counterpart to existing rejection test; catches > vs >= off-by-one)test_failed_create_tx_refunds_intrinsic_new_accountwith an expectation around gas used in tx receipt🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture