fix(testing): remove ignored StateTest engine_api_error_code#2740
Open
junbyjun1238 wants to merge 1 commit intoethereum:forks/amsterdamfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Remove
engine_api_error_codefromStateTest.StateTestcurrently exposesengine_api_error_code, but the value is silently dropped during theStateTest -> Blockconversion in state.py. The native state-fixture path does not consume it either, so the current API advertises a field that is effectively ignored.This field no longer matches the current codebase's abstraction:
engine_api_error_codeis modeled as block/payload metadata in blockchain.py and fixtures/blockchain.pyBlock(...), notStateTest(...)block_exception, it is not wired through_generate_blockchain_blocks()and has no in-treeStateTest(...)call sitesRemoving the field makes the API honest and avoids a footgun where a test author can specify an Engine API error expectation that is silently ignored. With BaseTest configured as
extra="forbid", unsupported usage will fail fast at model construction rather than being silently ignored.🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.Cute Animal Picture