Skip to content

refactor(forks): pass fork overrides to clone#2769

Open
JackCC703 wants to merge 1 commit intoethereum:forks/amsterdamfrom
JackCC703:fork-overrides-clone
Open

refactor(forks): pass fork overrides to clone#2769
JackCC703 wants to merge 1 commit intoethereum:forks/amsterdamfrom
JackCC703:fork-overrides-clone

Conversation

@JackCC703
Copy link
Copy Markdown
Contributor

🗒️ Description

Move the fork override dataclass from ethereum_spec_tools.evm_tools.t8n into ethereum_spec_tools.forks, and pass it directly into Hardfork.clone.

This keeps the existing ForkCache.get(...) call surface unchanged while reducing the long Hardfork.clone(...) parameter list.

🔗 Related Issues or PRs

Follow-up to #2738.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
    just was not installed locally, so I ran the equivalent commands from the static recipe manually.
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Cute dog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant