Skip to content

feat(spec-specs, tests): EIP-8037 drop double refund on incorporate_child_on_error#2822

Closed
spencer-tb wants to merge 2 commits into
ethereum:devnets/bal/7from
spencer-tb:feat/eip-8037-drop-double-refund
Closed

feat(spec-specs, tests): EIP-8037 drop double refund on incorporate_child_on_error#2822
spencer-tb wants to merge 2 commits into
ethereum:devnets/bal/7from
spencer-tb:feat/eip-8037-drop-double-refund

Conversation

@spencer-tb

Copy link
Copy Markdown
Contributor

🗒️ Description

Drops the state_gas_refund subtract in incorporate_child_on_error. The subtract over-billed the user by the refunded amount on any failure boundary that contained an inline credit (SSTORE 0→x→0 or CREATE silent failure), in both same-frame and cross-frame variants. With the subtract removed, parent.state_gas_left += child.state_gas_used + child.state_gas_left is sum-conserving and correctly restores the reservoir on revert/halt.

Addresses bullet 3 of #2804.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb

Copy link
Copy Markdown
Contributor Author

Superseded — folded into #2823.

@spencer-tb spencer-tb closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant