refactor(test-benchmark): update test_account_access, add keccak256 overhead scenario

[LouisTsai-Csie]

🗒️ Description

The original test_account_access targets contracts created by the Bittrex controller factory. This requires CREATE address calculations, introducing significant overhead and it is hard to precisely control over EXP and KECCAK256 inputs.

We introduced several changes in this PR:

• Move the test_account_access from test_single_opcode.py to test_account_query.py
• Remove the EXISTING_CONTRACT parametrization, adding EXISTING_CONTRACT_MINIMAL, EXISTING_CONTRACT_SAME and EXISTING_CONTRACT_DIFF parametrization.
• Add two helper files under tests/benchmark/helper: account_creator.py and account_sender_receiver.py -> we should remove tests/benchmark/{compute, stateful}/helpers.py in the future to share the helper function.
• Add test_deploy_existing_contracts that would be used for contract deployment, this includes deploying EXISTING_CONTRACT_* instance and necessary delegation.

deployed contract and initcode for each parametrization:

EXISTING_CONTRACT_MINIMAL
initcode: RETURN(PUSH1(0), PUSH1(1))
deployed code: STOP

EXISTING_CONTRACT_SAME
initcode:

seed 32 bytes of JUMPDEST (5b) at mem[0]
for size in 32, 64, ..., 16384:
    MCOPY mem[0:size] -> mem[size:2*size] # doubles filled region

mem[0] = 0x00 # MSTORE8: STOP

RETURN mem[0:max_code_size]

deployed code:

STOP JUMPDEST JUMPDEST ... ... ... JUMPDEST (fill until max code size)

EXISTING_CONTRACT_DIFF
initcode:

seed 32 bytes of JUMPDEST (5b) at mem[0]
for size in 32, 64, ..., 16384:
    MCOPY mem[0:size] -> mem[size:2*size] # doubles filled region

mem[0] = ADDRESS # MSTORE: ADDRESS

RETURN mem[0:max_code_size]

deployed code:

STOP STOP ... STOP ADDRESS JUMPDEST ... ... ... JUMPDEST (fill until max code size)

• code[0:12] = STOP
• code[12:32] = code address, which should be different for each contract

🔗 Related Issues or PRs

N/A.

✅ Checklist

• All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  just static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (45fb08e) to head (e6ad6ea).
⚠️ Report is 11 commits behind head on forks/amsterdam.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           forks/amsterdam    #2947      +/-   ##
===================================================
+ Coverage            90.32%   93.21%   +2.88%     
===================================================
  Files                  620      620              
  Lines                36686    38793    +2107     
  Branches              3341     3342       +1     
===================================================
+ Hits                 33138    36160    +3022     
+ Misses                2979     1773    -1206     
- Partials               569      860     +291     

Flag	Coverage Δ
unittests	93.21% <ø> (+2.88%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LouisTsai-Csie]

I've rebased the PR and updated the description, please review and integrate contract deployment into state-actor. cc @jochem-brouwer

[jochem-brouwer]

Some small comments!

[jochem-brouwer]

It helps if this has the hint 1 << 5 = 32 (so the first MCOPY is Op.MCOPY(32, 0, 32) (so it copies the just MSTOREd 32 bytes of JUMPDEST from 0-32 to offset 32, i.e. doubles the memory which has JUMPDEST, and the initial code for this is correct)

[LouisTsai-Csie]

Based on my current understanding, we want to do the repricing based on the old max code size value (0x6000), could you please confirm? cc @jochem-brouwer

This is applied to all the following contract variants. Note that if i use fork.max_code_size() instead, this would be affected by eip-7954.

[LouisTsai-Csie]

Starting from this range, we delegate to EXISTING_CONTRACT_DIFF contracts for a certain count. See test_deploy_existing_contracts. I need to verify if the current count is sufficient.