Skip to content

chore(test-forks): include sibling BPO forks in --until ranges#2955

Open
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:fix/until-includes-bpo-siblings
Open

chore(test-forks): include sibling BPO forks in --until ranges#2955
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:fix/until-includes-bpo-siblings

Conversation

@spencer-tb
Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb commented Jun 4, 2026

🗒️ Description

Currently when filling with --until Amsterdam, we are missing tests that use the BPO3/4/5 test constants.

This PR updates --until to include them so we don't miss mainnet coverage in releases.

The missing tests are denoted below (96 cases):

  • tests/cancun/eip4844_blobs/
    • test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis
  • tests/osaka/eip7918_blob_reserve_price/
    • test_blob_reserve_price_with_bpo_transitions.py::test_reserve_price_at_transition

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@spencer-tb spencer-tb added C-chore Category: chore A-test-forks Area: execution_testing.forks labels Jun 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (852715c) to head (a5cea90).
⚠️ Report is 35 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2955      +/-   ##
===================================================
+ Coverage            87.16%   90.50%   +3.34%     
===================================================
  Files                  586      535      -51     
  Lines                35792    32407    -3385     
  Branches              3364     3011     -353     
===================================================
- Hits                 31199    29331    -1868     
+ Misses                3943     2559    -1384     
+ Partials               650      517     -133     
Flag Coverage Δ
unittests 90.50% <ø> (+3.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb force-pushed the fix/until-includes-bpo-siblings branch from 7119c79 to a5cea90 Compare June 4, 2026 12:16
Copy link
Copy Markdown
Contributor

@felix314159 felix314159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment only, thanks.

single_fork: Set[Type[BaseFork]],
forks_from: Set[Type[BaseFork]],
forks_until: Set[Type[BaseFork]],
transition_forks: bool = True,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least we should add a parameter here to disable this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-forks Area: execution_testing.forks C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants