Skip to content

fix(tooling): include namespace packages in coverage reports#2982

Merged
danceratopz merged 2 commits into
ethereum:forks/amsterdamfrom
danceratopz:include-namespace-packages-in-coverage
Jun 15, 2026
Merged

fix(tooling): include namespace packages in coverage reports#2982
danceratopz merged 2 commits into
ethereum:forks/amsterdamfrom
danceratopz:include-namespace-packages-in-coverage

Conversation

@danceratopz

@danceratopz danceratopz commented Jun 11, 2026

Copy link
Copy Markdown
Member

🗒️ Description

Enable coverage.py's include_namespace_packages option so that never-imported modules under the ethereum.forks namespace package count towards the coverage denominator (at 0%); this gives all coverage uploads the same denominator and explains the apparent coverage drop seen in #2975, where fill-only reports silently excluded the never-imported spurious_dragon and tangerine_whistle fork trees.

🔗 Related Issues or PRs

Related to #2975.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

A cute dog

@danceratopz danceratopz added C-bug Category: this is a bug, deviation, or other problem A-tooling Area: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ... labels Jun 11, 2026
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.28%. Comparing base (54246cd) to head (1afb5eb).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2982      +/-   ##
===================================================
- Coverage            90.52%   81.28%   -9.24%     
===================================================
  Files                  535      620      +85     
  Lines                32903    36643    +3740     
  Branches              3022     3311     +289     
===================================================
  Hits                 29786    29786              
- Misses                2595     6335    +3740     
  Partials               522      522              
Flag Coverage Δ
unittests 81.28% <ø> (-9.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SamWilsn SamWilsn force-pushed the include-namespace-packages-in-coverage branch from 321d465 to 1afb5eb Compare June 15, 2026 17:23
@danceratopz

Copy link
Copy Markdown
Member Author

Thanks @SamWilsn.

@danceratopz danceratopz merged commit 94f7d12 into ethereum:forks/amsterdam Jun 15, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tooling Area: Improvements or changes to auxiliary tooling such as uv, ruff, mypy, ... C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants