chore(ci): speed up json-loader and fill jobs#3096
Open
spencer-tb wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3096 +/- ##
===================================================
+ Coverage 93.23% 93.30% +0.06%
===================================================
Files 624 624
Lines 36924 36986 +62
Branches 3373 3383 +10
===================================================
+ Hits 34427 34510 +83
+ Misses 1704 1694 -10
+ Partials 793 782 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
force-pushed
the
ci/json-loader-speedup
branch
from
a03cb33 to
46ad799
Compare
spencer-tb
force-pushed
the
ci/json-loader-speedup
branch
from
46ad799 to
a4efbc7
Compare
spencer-tb
changed the title
spencer-tb
force-pushed
the
ci/json-loader-speedup
branch
from
cfde400 to
d30dcfa
Compare
4 tasks
SamWilsn
reviewed
Jul 3, 2026
| [group('unit tests')] | ||
| test-tests *args: | ||
| @mkdir -p "{{ output_dir }}/test-tests/tmp" | ||
| @mkdir -p "{{ output_dir }}/test-tests/tmp" "{{ output_dir }}/test-tests/tmp-evm-tools" |
Contributor
There was a problem hiding this comment.
Might be worth defining a Just variable for the temp dir, or better yet, use something like recipe_name to factor out making temp dirs from all the recipes.
| -m "not slow and (blockchain_test or state_test_only or blockchain_test_engine_only)" | ||
| env: | ||
| PYTEST_XDIST_AUTO_NUM_WORKERS: auto | ||
| COVERAGE_CORE: sysmon |
Contributor
There was a problem hiding this comment.
Is there a reason you shouldn't define this in the Justfile? Seems like it would be just as useful for local builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Speed up the per-PR CI by:
tests/evm_tools, run by test-tests)sys.monitoringcorejson-loaderdrops from ~7m to ~4m30s (was the current bottleneck) andfill (amsterdam)from ~5m30s to ~4m (the next bottleneck).🔗 Related Issues or PRs
Additionally fixes #3022.
✅ Checklist
just static<type>(<area>):, where<type>and<area>come from an approrpriateC-<type>, respectivelyA-<area>, label. The title should match the a target squash commit message.Cute Animal Picture