feat(fork-types): add RegularGas and StateGas NewType wrappers to ams…#3121
Open
mandeepmourya007 wants to merge 1 commit into
Open
feat(fork-types): add RegularGas and StateGas NewType wrappers to ams…#3121mandeepmourya007 wants to merge 1 commit into
mandeepmourya007 wants to merge 1 commit into
Conversation
…terdam EVM Applies the RegularGas and StateGas NewType wrappers (introduced in fork_types.py) to all EVM gas fields and constants across the amsterdam fork, preventing accidental mixing of state-gas with regular-gas. - Types all GasCosts constants, ExtendMemory.cost, MessageCallGas fields - Types Evm.gas_left/state_gas_left/regular_gas_used/state_gas_spilled - Types Message.gas/state_gas_reservoir and TransactionEnvironment fields - Types MessageCallOutput gas fields and GenericCall parameters - Updates max_message_call_gas and calculate_delegation_cost return types Closes ethereum#3015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applies the
RegularGasandStateGasNewTypewrappers (introduced infork_types.pyby #3037) to all EVM gas fields and constants across theamsterdam fork, preventing accidental mixing of state-gas with regular-gas
at the type level.
Changes:
GasCostsconstants typed asRegularGas;StateGasCostsalready typed asStateGasEvm.gas_left,state_gas_left,regular_gas_used,state_gas_spilledtypedMessage.gas,state_gas_reservoirandTransactionEnvironmentfields typedMessageCallOutputandGenericCallgas fields typedmax_message_call_gasandcalculate_delegation_costreturn types updated toRegularGasRelated Issues or PRs
Closes #3015. Follows on from #3037.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture