Skip to content

feat(tests): add dynamic-destination JUMP/JUMPI invalid-target tests#3153

Open
chfast wants to merge 1 commit into
ethereum:forks/amsterdamfrom
chfast:dynamic-jump-tests
Open

feat(tests): add dynamic-destination JUMP/JUMPI invalid-target tests#3153
chfast wants to merge 1 commit into
ethereum:forks/amsterdamfrom
chfast:dynamic-jump-tests

Conversation

@chfast

@chfast chfast commented Jul 13, 2026

Copy link
Copy Markdown
Member

Description

Port the behaviors of the legacy VMTests dynamic-jump family (DynamicJump*, BlockNumberDynamicJump*, JDfromStorageDynamicJump*, bad_indirect_jump2, jumpi1) that had no EEST equivalent: jumps with runtime-computed destinations landing inside PUSH immediate data (on 0x5B and non-0x5B bytes) or far beyond code size, and a not-taken JUMPI with an invalid static destination.

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Port the behaviors of the legacy VMTests dynamic-jump family
(DynamicJump*, BlockNumberDynamicJump*, JDfromStorageDynamicJump*,
bad_indirect_jump2, jumpi1) that had no EEST equivalent: jumps with
runtime-computed destinations landing inside PUSH immediate data (on
0x5B and non-0x5B bytes) or far beyond code size, and a not-taken
JUMPI with an invalid static destination.
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.37%. Comparing base (0f8b81b) to head (42c92bd).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #3153      +/-   ##
===================================================
+ Coverage            93.30%   93.37%   +0.07%     
===================================================
  Files                  624      624              
  Lines                36991    36991              
  Branches              3384     3384              
===================================================
+ Hits                 34515    34541      +26     
+ Misses                1694     1681      -13     
+ Partials               782      769      -13     
Flag Coverage Δ
unittests 93.37% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chfast
chfast force-pushed the dynamic-jump-tests branch from a16fbc1 to 42c92bd Compare July 13, 2026 10:37
@marioevz
marioevz self-requested a review July 14, 2026 12:48
@marioevz marioevz self-assigned this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants