fix(test-specs): use integer division for genesis base fee#3189
Open
cuiweixie wants to merge 1 commit into
Open
fix(test-specs): use integer division for genesis base fee#3189cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
Avoid float64 (53-bit mantissa) precision loss when scaling base_fee_per_gas by 8/7 for values beyond 2^53.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deriving the genesis
base_fee_per_gasfrom a state test's block#1 env (* 8 / 7), the previous code used float division (/→float), then cast back withint(...).IEEE-754
float64only has a 53-bit mantissa, so integers larger than2^53are not represented exactly. For largebase_fee_per_gasvalues this can silently round before the integer conversion, producing an incorrect genesis base fee.This change switches to pure integer arithmetic (
* 8 // 7) so the scaling stays exact for arbitrary-size integers.Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture