fix(test-specs): parenthesize walrus when counting failing txs#3190
Open
cuiweixie wants to merge 1 commit into
Open
fix(test-specs): parenthesize walrus when counting failing txs#3190cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
Without parentheses, `:=` binds after `>`, so failing_tx_count became a bool and the multi-failure check never fired.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3190 +/- ##
================================================
Coverage 93.39% 93.39%
================================================
Files 624 624
Lines 37014 37014
Branches 3386 3386
================================================
Hits 34570 34570
Misses 1671 1671
Partials 773 773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix operator precedence around the walrus assignment when counting failing transactions:
Previously
failing_tx_countwas alwaysTrue/False, sofailing_tx_count > 1never detected multiple failing transactions and the correctness check was effectively dead.Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture